From: Arend van Spriel <arend@broadcom.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Arend van Spriel <arend@broadcom.com>
Subject: [PATCH 8/8] brcmfmac: reduce log level in fwil if firmware returns error
Date: Sat, 21 Jun 2014 12:11:19 +0200 [thread overview]
Message-ID: <1403345479-13467-9-git-send-email-arend@broadcom.com> (raw)
In-Reply-To: <1403345479-13467-1-git-send-email-arend@broadcom.com>
The users of the fwil put an error message in the log so there is
no need to do the same in the lower level functions in fwil when
the firmware on the device returns an error. Some errors can be
ignored for the driver to function and this will avoid driver users
to point at the low-level error message as potential bug.
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
index 59a5af5..ded328f 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c
@@ -54,7 +54,7 @@ brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
if (err >= 0)
err = 0;
else
- brcmf_err("Failed err=%d\n", err);
+ brcmf_dbg(FIL, "Failed err=%d\n", err);
return err;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-06-21 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 10:11 [PATCH 0/8] brcmfmac: new USB devices, vendor command, and cleanup Arend van Spriel
2014-06-21 10:11 ` [PATCH 1/8] brcmfmac: Add 43569 USB support Arend van Spriel
2014-06-21 10:11 ` [PATCH 2/8] brcmfmac: Add USB device 43566 to supported devices Arend van Spriel
2014-06-21 15:55 ` Rafał Miłecki
2014-06-21 16:56 ` Arend van Spriel
2014-06-21 10:11 ` [PATCH 3/8] brcmfmac: clear ht info during attach phase Arend van Spriel
2014-06-21 10:11 ` [PATCH 4/8] brcmfmac: Change USB probe routine to support Composite USB Arend van Spriel
2014-06-21 10:11 ` [PATCH 5/8] brcmfmac: replace cfg80211 testmode with vendor command Arend van Spriel
2014-06-21 10:11 ` [PATCH 6/8] brcmfmac: correct logging levels in btcoex source Arend van Spriel
2014-06-21 10:11 ` [PATCH 7/8] brcmfmac: Don't control mpc setting during scan operation Arend van Spriel
2014-06-21 10:11 ` Arend van Spriel [this message]
2014-06-21 15:58 ` [PATCH 0/8] brcmfmac: new USB devices, vendor command, and cleanup Rafał Miłecki
2014-06-21 16:48 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403345479-13467-9-git-send-email-arend@broadcom.com \
--to=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).