From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Luca Coelho <luca@coelho.fi>
Subject: Re: [PATCH v10 1/5] mac80211: implement multi-vif in-place reservations
Date: Tue, 24 Jun 2014 13:59:06 +0200 [thread overview]
Message-ID: <1403611146.10831.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQkNKQq2vQ1OY9jt9S4uvgWGuSn9NvwjTfZZOYMxB3_1QQ@mail.gmail.com> (sfid-20140624_135524_109890_341E226D)
On Tue, 2014-06-24 at 13:55 +0200, Michal Kazior wrote:
> >> + if (WARN_ON(!ctx->replace_ctx))
> >> + return -EINVAL;
> >
> > This also leaks "vif_chsw".
>
> This should be a `goto` too.
This was the first thing I'd actually looked at, and there's currently
no label that frees vif_chsw :)
> I'll re-spin once I fix all the problems that I'm aware of now.
Thanks.
johannes
next prev parent reply other threads:[~2014-06-24 11:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 7:34 [PATCH v7 0/5] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-05-29 7:34 ` [PATCH v7 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-02 11:33 ` Luca Coelho
2014-06-03 6:15 ` Michal Kazior
2014-06-03 17:10 ` Johannes Berg
2014-06-04 12:12 ` Michal Kazior
2014-06-04 12:38 ` Johannes Berg
2014-05-29 7:34 ` [PATCH v7 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-05-29 7:34 ` [PATCH v7 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-03 19:49 ` Johannes Berg
2014-05-29 7:34 ` [PATCH v7 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-05-29 7:34 ` [PATCH v7 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-03 19:51 ` [PATCH v7 0/5] cfg/mac80211: implement multi-vif csa Johannes Berg
2014-06-05 12:56 ` [PATCH v8 " Michal Kazior
2014-06-05 12:56 ` [PATCH v8 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-09 16:27 ` Eliad Peller
2014-06-10 5:16 ` Michal Kazior
2014-06-05 12:56 ` [PATCH v8 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-06-05 12:56 ` [PATCH v8 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-05 12:56 ` [PATCH v8 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-06-05 12:56 ` [PATCH v8 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-12 12:54 ` [PATCH v9 0/5] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-06-12 12:54 ` [PATCH v9 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-16 14:35 ` Luca Coelho
2014-06-17 5:52 ` Michal Kazior
2014-06-12 12:54 ` [PATCH v9 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-06-12 12:54 ` [PATCH v9 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-12 12:54 ` [PATCH v9 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-06-12 12:54 ` [PATCH v9 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-17 12:58 ` [PATCH v10 0/5] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-06-17 12:58 ` [PATCH v10 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-23 13:03 ` Johannes Berg
2014-06-24 11:55 ` Michal Kazior
2014-06-24 11:59 ` Johannes Berg [this message]
2014-06-17 12:58 ` [PATCH v10 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-06-17 12:58 ` [PATCH v10 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-17 12:58 ` [PATCH v10 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-06-17 12:58 ` [PATCH v10 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-23 10:46 ` [PATCH v10 0/5] cfg/mac80211: implement multi-vif csa Luca Coelho
2014-06-23 13:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403611146.10831.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).