From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:57654 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbaGBOGE (ORCPT ); Wed, 2 Jul 2014 10:06:04 -0400 Message-ID: <1404309961.5102.35.camel@smile.fi.intel.com> (sfid-20140702_160623_471433_294EBF31) Subject: Re: [PATCH 3/6] lib80211: re-use string_escape_mem_any_np() From: Andy Shevchenko To: Joe Perches Cc: "John W. Linville" , Johannes Berg , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Andrew Morton Date: Wed, 02 Jul 2014 17:06:01 +0300 In-Reply-To: <1404308611.14624.78.camel@joe-AO725> References: <1404307229-19186-1-git-send-email-andriy.shevchenko@linux.intel.com> <1404307229-19186-4-git-send-email-andriy.shevchenko@linux.intel.com> <1404308611.14624.78.camel@joe-AO725> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2014-07-02 at 06:43 -0700, Joe Perches wrote: > On Wed, 2014-07-02 at 16:20 +0300, Andy Shevchenko wrote: > > In kernel we have function to escape a given string. Let's use it instead of > > custom approach. > > > > This fixes a bug. The current implementation wrongly prints octal numbers: only > > two first digits are used in case when 3 are required and the rest of the > > string ends up cut off. [] > This code looks like it was adapted from the old print_mac > ethernet code that was eventually replaced by a vsprintf > pointer extension %pM > > So a better way to do this might be to add and use yet > another vsprintf %p extension for ssids. Might be, but it - doesn't reduce necessity of string_escape_mem (not only ssid are escaped in kernel) - prevents user to choose a rule what exactly their would like to escape (look at the other patches against ssid escaping) -- Andy Shevchenko Intel Finland Oy