linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] staging: vt6656: rf.c clean up channel and power tables
@ 2014-07-12 10:30 Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 2/4] staging: vt6656: rf.c remove dead code RFaby11aChannelIndex Malcolm Priestley
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Malcolm Priestley @ 2014-07-12 10:30 UTC (permalink / raw)
  To: gregkh; +Cc: linux-wireless, Malcolm Priestley

Remove comments to channel number execpt where there is a
change to 5gHz channel 15

named comments are already referenced in revision history
in high-level comment.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6656/rf.c | 1077 +++++++++++++++++++++----------------------
 1 file changed, 515 insertions(+), 562 deletions(-)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 4124131..f203dde 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -61,531 +61,484 @@
 //}}
 
 static u8 al2230_init_table[CB_AL2230_INIT_SEQ][3] = {
-    {0x03, 0xF7, 0x90},
-    {0x03, 0x33, 0x31},
-    {0x01, 0xB8, 0x02},
-    {0x00, 0xFF, 0xF3},
-    {0x00, 0x05, 0xA4},
-    {0x0F, 0x4D, 0xC5},   //RobertYu:20060814
-    {0x08, 0x05, 0xB6},
-    {0x01, 0x47, 0xC7},
-    {0x00, 0x06, 0x88},
-    {0x04, 0x03, 0xB9},
-    {0x00, 0xDB, 0xBA},
-    {0x00, 0x09, 0x9B},
-    {0x0B, 0xDF, 0xFC},
-    {0x00, 0x00, 0x0D},
-    {0x00, 0x58, 0x0F}
-    };
+	{0x03, 0xf7, 0x90},
+	{0x03, 0x33, 0x31},
+	{0x01, 0xb8, 0x02},
+	{0x00, 0xff, 0xf3},
+	{0x00, 0x05, 0xa4},
+	{0x0f, 0x4d, 0xc5},
+	{0x08, 0x05, 0xb6},
+	{0x01, 0x47, 0xc7},
+	{0x00, 0x06, 0x88},
+	{0x04, 0x03, 0xb9},
+	{0x00, 0xdb, 0xba},
+	{0x00, 0x09, 0x9b},
+	{0x0b, 0xdf, 0xfc},
+	{0x00, 0x00, 0x0d},
+	{0x00, 0x58, 0x0f}
+};
 
 static u8 al2230_channel_table0[CB_MAX_CHANNEL_24G][3] = {
-    {0x03, 0xF7, 0x90}, // channel = 1, Tf = 2412MHz
-    {0x03, 0xF7, 0x90}, // channel = 2, Tf = 2417MHz
-    {0x03, 0xE7, 0x90}, // channel = 3, Tf = 2422MHz
-    {0x03, 0xE7, 0x90}, // channel = 4, Tf = 2427MHz
-    {0x03, 0xF7, 0xA0}, // channel = 5, Tf = 2432MHz
-    {0x03, 0xF7, 0xA0}, // channel = 6, Tf = 2437MHz
-    {0x03, 0xE7, 0xA0}, // channel = 7, Tf = 2442MHz
-    {0x03, 0xE7, 0xA0}, // channel = 8, Tf = 2447MHz
-    {0x03, 0xF7, 0xB0}, // channel = 9, Tf = 2452MHz
-    {0x03, 0xF7, 0xB0}, // channel = 10, Tf = 2457MHz
-    {0x03, 0xE7, 0xB0}, // channel = 11, Tf = 2462MHz
-    {0x03, 0xE7, 0xB0}, // channel = 12, Tf = 2467MHz
-    {0x03, 0xF7, 0xC0}, // channel = 13, Tf = 2472MHz
-    {0x03, 0xE7, 0xC0}  // channel = 14, Tf = 2412M
-    };
+	{0x03, 0xf7, 0x90},
+	{0x03, 0xf7, 0x90},
+	{0x03, 0xe7, 0x90},
+	{0x03, 0xe7, 0x90},
+	{0x03, 0xf7, 0xa0},
+	{0x03, 0xf7, 0xa0},
+	{0x03, 0xe7, 0xa0},
+	{0x03, 0xe7, 0xa0},
+	{0x03, 0xf7, 0xb0},
+	{0x03, 0xf7, 0xb0},
+	{0x03, 0xe7, 0xb0},
+	{0x03, 0xe7, 0xb0},
+	{0x03, 0xf7, 0xc0},
+	{0x03, 0xe7, 0xc0}
+};
 
 static u8 al2230_channel_table1[CB_MAX_CHANNEL_24G][3] = {
-    {0x03, 0x33, 0x31}, // channel = 1, Tf = 2412MHz
-    {0x0B, 0x33, 0x31}, // channel = 2, Tf = 2417MHz
-    {0x03, 0x33, 0x31}, // channel = 3, Tf = 2422MHz
-    {0x0B, 0x33, 0x31}, // channel = 4, Tf = 2427MHz
-    {0x03, 0x33, 0x31}, // channel = 5, Tf = 2432MHz
-    {0x0B, 0x33, 0x31}, // channel = 6, Tf = 2437MHz
-    {0x03, 0x33, 0x31}, // channel = 7, Tf = 2442MHz
-    {0x0B, 0x33, 0x31}, // channel = 8, Tf = 2447MHz
-    {0x03, 0x33, 0x31}, // channel = 9, Tf = 2452MHz
-    {0x0B, 0x33, 0x31}, // channel = 10, Tf = 2457MHz
-    {0x03, 0x33, 0x31}, // channel = 11, Tf = 2462MHz
-    {0x0B, 0x33, 0x31}, // channel = 12, Tf = 2467MHz
-    {0x03, 0x33, 0x31}, // channel = 13, Tf = 2472MHz
-    {0x06, 0x66, 0x61}  // channel = 14, Tf = 2412M
-    };
-
-// 40MHz reference frequency
-// Need to Pull PLLON(PE3) low when writing channel registers through 3-wire.
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x06, 0x66, 0x61}
+};
+
 static u8 al7230_init_table[CB_AL7230_INIT_SEQ][3] = {
-    {0x20, 0x37, 0x90}, // Channel1 // Need modify for 11a
-    {0x13, 0x33, 0x31}, // Channel1 // Need modify for 11a
-    {0x84, 0x1F, 0xF2}, // Need modify for 11a: 451FE2
-    {0x3F, 0xDF, 0xA3}, // Need modify for 11a: 5FDFA3
-    {0x7F, 0xD7, 0x84}, // 11b/g    // Need modify for 11a
-    //0x802B4500+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW, // Need modify for 11a: 8D1B45
-    // RoberYu:20050113, Rev0.47 Regsiter Setting Guide
-    {0x80, 0x2B, 0x55}, // Need modify for 11a: 8D1B55
-    {0x56, 0xAF, 0x36},
-    {0xCE, 0x02, 0x07}, // Need modify for 11a: 860207
-    {0x6E, 0xBC, 0x98},
-    {0x22, 0x1B, 0xB9},
-    {0xE0, 0x00, 0x0A}, // Need modify for 11a: E0600A
-    {0x08, 0x03, 0x1B}, // init 0x080B1B00 => 0x080F1B00 for 3 wire control TxGain(D10)
-    //0x00093C00+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW, // Need modify for 11a: 00143C
-    // RoberYu:20050113, Rev0.47 Regsiter Setting Guide
-    {0x00, 0x0A, 0x3C}, // Need modify for 11a: 00143C
-    {0xFF, 0xFF, 0xFD},
-    {0x00, 0x00, 0x0E},
-    {0x1A, 0xBA, 0x8F} // Need modify for 11a: 12BACF
-    };
+	{0x20, 0x37, 0x90},
+	{0x13, 0x33, 0x31},
+	{0x84, 0x1f, 0xf2},
+	{0x3f, 0xdf, 0xa3},
+	{0x7f, 0xd7, 0x84},
+	{0x80, 0x2b, 0x55},
+	{0x56, 0xaf, 0x36},
+	{0xce, 0x02, 0x07},
+	{0x6e, 0xbc, 0x98},
+	{0x22, 0x1b, 0xb9},
+	{0xe0, 0x00, 0x0a},
+	{0x08, 0x03, 0x1b},
+	{0x00, 0x0a, 0x3c},
+	{0xff, 0xff, 0xfd},
+	{0x00, 0x00, 0x0e},
+	{0x1a, 0xba, 0x8f}
+};
 
 static u8 al7230_init_table_amode[CB_AL7230_INIT_SEQ][3] = {
-    {0x2F, 0xF5, 0x20}, // Channel184 // Need modify for 11b/g
-    {0x00, 0x00, 0x01}, // Channel184 // Need modify for 11b/g
-    {0x45, 0x1F, 0xE2}, // Need modify for 11b/g
-    {0x5F, 0xDF, 0xA3}, // Need modify for 11b/g
-    {0x6F, 0xD7, 0x84}, // 11a    // Need modify for 11b/g
-    {0x85, 0x3F, 0x55}, // Need modify for 11b/g, RoberYu:20050113
-    {0x56, 0xAF, 0x36},
-    {0xCE, 0x02, 0x07}, // Need modify for 11b/g
-    {0x6E, 0xBC, 0x98},
-    {0x22, 0x1B, 0xB9},
-    {0xE0, 0x60, 0x0A}, // Need modify for 11b/g
-    {0x08, 0x03, 0x1B}, // init 0x080B1B00 => 0x080F1B00 for 3 wire control TxGain(D10)
-    {0x00, 0x14, 0x7C}, // Need modify for 11b/g
-    {0xFF, 0xFF, 0xFD},
-    {0x00, 0x00, 0x0E},
-    {0x12, 0xBA, 0xCF} // Need modify for 11b/g
-    };
+	{0x2f, 0xf5, 0x20},
+	{0x00, 0x00, 0x01},
+	{0x45, 0x1f, 0xe2},
+	{0x5f, 0xdf, 0xa3},
+	{0x6f, 0xd7, 0x84},
+	{0x85, 0x3f, 0x55},
+	{0x56, 0xaf, 0x36},
+	{0xce, 0x02, 0x07},
+	{0x6e, 0xbc, 0x98},
+	{0x22, 0x1b, 0xb9},
+	{0xe0, 0x60, 0x0a},
+	{0x08, 0x03, 0x1b},
+	{0x00, 0x14, 0x7c},
+	{0xff, 0xff, 0xfd},
+	{0x00, 0x00, 0x0e},
+	{0x12, 0xba, 0xcf}
+};
 
 static u8 al7230_channel_table0[CB_MAX_CHANNEL][3] = {
-    {0x20, 0x37, 0x90}, // channel =  1, Tf = 2412MHz
-    {0x20, 0x37, 0x90}, // channel =  2, Tf = 2417MHz
-    {0x20, 0x37, 0x90}, // channel =  3, Tf = 2422MHz
-    {0x20, 0x37, 0x90}, // channel =  4, Tf = 2427MHz
-    {0x20, 0x37, 0xA0}, // channel =  5, Tf = 2432MHz
-    {0x20, 0x37, 0xA0}, // channel =  6, Tf = 2437MHz
-    {0x20, 0x37, 0xA0}, // channel =  7, Tf = 2442MHz
-    {0x20, 0x37, 0xA0}, // channel =  8, Tf = 2447MHz //RobertYu: 20050218, update for APNode 0.49
-    {0x20, 0x37, 0xB0}, // channel =  9, Tf = 2452MHz //RobertYu: 20050218, update for APNode 0.49
-    {0x20, 0x37, 0xB0}, // channel = 10, Tf = 2457MHz //RobertYu: 20050218, update for APNode 0.49
-    {0x20, 0x37, 0xB0}, // channel = 11, Tf = 2462MHz //RobertYu: 20050218, update for APNode 0.49
-    {0x20, 0x37, 0xB0}, // channel = 12, Tf = 2467MHz //RobertYu: 20050218, update for APNode 0.49
-    {0x20, 0x37, 0xC0}, // channel = 13, Tf = 2472MHz //RobertYu: 20050218, update for APNode 0.49
-    {0x20, 0x37, 0xC0}, // channel = 14, Tf = 2484MHz
-
-    // 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-    {0x0F, 0xF5, 0x20}, // channel = 183, Tf = 4915MHz (15)
-    {0x2F, 0xF5, 0x20}, // channel = 184, Tf = 4920MHz (16)
-    {0x0F, 0xF5, 0x20}, // channel = 185, Tf = 4925MHz (17)
-    {0x0F, 0xF5, 0x20}, // channel = 187, Tf = 4935MHz (18)
-    {0x2F, 0xF5, 0x20}, // channel = 188, Tf = 4940MHz (19)
-    {0x0F, 0xF5, 0x20}, // channel = 189, Tf = 4945MHz (20)
-    {0x2F, 0xF5, 0x30}, // channel = 192, Tf = 4960MHz (21)
-    {0x2F, 0xF5, 0x30}, // channel = 196, Tf = 4980MHz (22)
-
-    // 5G => Ch 7, 8, 9, 11, 12, 16, 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64,
-    // 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 149, 153, 157, 161, 165  (Value 23 ~ 56)
-
-    {0x0F, 0xF5, 0x40}, // channel =   7, Tf = 5035MHz (23)
-    {0x2F, 0xF5, 0x40}, // channel =   8, Tf = 5040MHz (24)
-    {0x0F, 0xF5, 0x40}, // channel =   9, Tf = 5045MHz (25)
-    {0x0F, 0xF5, 0x40}, // channel =  11, Tf = 5055MHz (26)
-    {0x2F, 0xF5, 0x40}, // channel =  12, Tf = 5060MHz (27)
-    {0x2F, 0xF5, 0x50}, // channel =  16, Tf = 5080MHz (28)
-    {0x2F, 0xF5, 0x60}, // channel =  34, Tf = 5170MHz (29)
-    {0x2F, 0xF5, 0x60}, // channel =  36, Tf = 5180MHz (30)
-    {0x2F, 0xF5, 0x70}, // channel =  38, Tf = 5190MHz (31) //RobertYu: 20050218, update for APNode 0.49
-    {0x2F, 0xF5, 0x70}, // channel =  40, Tf = 5200MHz (32)
-    {0x2F, 0xF5, 0x70}, // channel =  42, Tf = 5210MHz (33)
-    {0x2F, 0xF5, 0x70}, // channel =  44, Tf = 5220MHz (34)
-    {0x2F, 0xF5, 0x70}, // channel =  46, Tf = 5230MHz (35)
-    {0x2F, 0xF5, 0x70}, // channel =  48, Tf = 5240MHz (36)
-    {0x2F, 0xF5, 0x80}, // channel =  52, Tf = 5260MHz (37)
-    {0x2F, 0xF5, 0x80}, // channel =  56, Tf = 5280MHz (38)
-    {0x2F, 0xF5, 0x80}, // channel =  60, Tf = 5300MHz (39)
-    {0x2F, 0xF5, 0x90}, // channel =  64, Tf = 5320MHz (40)
-
-    {0x2F, 0xF5, 0xC0}, // channel = 100, Tf = 5500MHz (41)
-    {0x2F, 0xF5, 0xC0}, // channel = 104, Tf = 5520MHz (42)
-    {0x2F, 0xF5, 0xC0}, // channel = 108, Tf = 5540MHz (43)
-    {0x2F, 0xF5, 0xD0}, // channel = 112, Tf = 5560MHz (44)
-    {0x2F, 0xF5, 0xD0}, // channel = 116, Tf = 5580MHz (45)
-    {0x2F, 0xF5, 0xD0}, // channel = 120, Tf = 5600MHz (46)
-    {0x2F, 0xF5, 0xE0}, // channel = 124, Tf = 5620MHz (47)
-    {0x2F, 0xF5, 0xE0}, // channel = 128, Tf = 5640MHz (48)
-    {0x2F, 0xF5, 0xE0}, // channel = 132, Tf = 5660MHz (49)
-    {0x2F, 0xF5, 0xF0}, // channel = 136, Tf = 5680MHz (50)
-    {0x2F, 0xF5, 0xF0}, // channel = 140, Tf = 5700MHz (51)
-    {0x2F, 0xF6, 0x00}, // channel = 149, Tf = 5745MHz (52)
-    {0x2F, 0xF6, 0x00}, // channel = 153, Tf = 5765MHz (53)
-    {0x2F, 0xF6, 0x00}, // channel = 157, Tf = 5785MHz (54)
-    {0x2F, 0xF6, 0x10}, // channel = 161, Tf = 5805MHz (55)
-    {0x2F, 0xF6, 0x10} // channel = 165, Tf = 5825MHz (56)
-    };
+	{0x20, 0x37, 0x90},
+	{0x20, 0x37, 0x90},
+	{0x20, 0x37, 0x90},
+	{0x20, 0x37, 0x90},
+	{0x20, 0x37, 0xa0},
+	{0x20, 0x37, 0xa0},
+	{0x20, 0x37, 0xa0},
+	{0x20, 0x37, 0xa0},
+	{0x20, 0x37, 0xb0},
+	{0x20, 0x37, 0xb0},
+	{0x20, 0x37, 0xb0},
+	{0x20, 0x37, 0xb0},
+	{0x20, 0x37, 0xc0},
+	{0x20, 0x37, 0xc0},
+	{0x0f, 0xf5, 0x20}, /* channel 15 Tf = 4915MHz */
+	{0x2f, 0xf5, 0x20},
+	{0x0f, 0xf5, 0x20},
+	{0x0f, 0xf5, 0x20},
+	{0x2f, 0xf5, 0x20},
+	{0x0f, 0xf5, 0x20},
+	{0x2f, 0xf5, 0x30},
+	{0x2f, 0xf5, 0x30},
+	{0x0f, 0xf5, 0x40},
+	{0x2f, 0xf5, 0x40},
+	{0x0f, 0xf5, 0x40},
+	{0x0f, 0xf5, 0x40},
+	{0x2f, 0xf5, 0x40},
+	{0x2f, 0xf5, 0x50},
+	{0x2f, 0xf5, 0x60},
+	{0x2f, 0xf5, 0x60},
+	{0x2f, 0xf5, 0x70},
+	{0x2f, 0xf5, 0x70},
+	{0x2f, 0xf5, 0x70},
+	{0x2f, 0xf5, 0x70},
+	{0x2f, 0xf5, 0x70},
+	{0x2f, 0xf5, 0x70},
+	{0x2f, 0xf5, 0x80},
+	{0x2f, 0xf5, 0x80},
+	{0x2f, 0xf5, 0x80},
+	{0x2f, 0xf5, 0x90},
+	{0x2f, 0xf5, 0xc0},
+	{0x2f, 0xf5, 0xc0},
+	{0x2f, 0xf5, 0xc0},
+	{0x2f, 0xf5, 0xd0},
+	{0x2f, 0xf5, 0xd0},
+	{0x2f, 0xf5, 0xd0},
+	{0x2f, 0xf5, 0xe0},
+	{0x2f, 0xf5, 0xe0},
+	{0x2f, 0xf5, 0xe0},
+	{0x2f, 0xf5, 0xf0},
+	{0x2f, 0xf5, 0xf0},
+	{0x2f, 0xf6, 0x00},
+	{0x2f, 0xf6, 0x00},
+	{0x2f, 0xf6, 0x00},
+	{0x2f, 0xf6, 0x10},
+	{0x2f, 0xf6, 0x10}
+};
 
 static u8 al7230_channel_table1[CB_MAX_CHANNEL][3] = {
-    {0x13, 0x33, 0x31}, // channel =  1, Tf = 2412MHz
-    {0x1B, 0x33, 0x31}, // channel =  2, Tf = 2417MHz
-    {0x03, 0x33, 0x31}, // channel =  3, Tf = 2422MHz
-    {0x0B, 0x33, 0x31}, // channel =  4, Tf = 2427MHz
-    {0x13, 0x33, 0x31}, // channel =  5, Tf = 2432MHz
-    {0x1B, 0x33, 0x31}, // channel =  6, Tf = 2437MHz
-    {0x03, 0x33, 0x31}, // channel =  7, Tf = 2442MHz
-    {0x0B, 0x33, 0x31}, // channel =  8, Tf = 2447MHz
-    {0x13, 0x33, 0x31}, // channel =  9, Tf = 2452MHz
-    {0x1B, 0x33, 0x31}, // channel = 10, Tf = 2457MHz
-    {0x03, 0x33, 0x31}, // channel = 11, Tf = 2462MHz
-    {0x0B, 0x33, 0x31}, // channel = 12, Tf = 2467MHz
-    {0x13, 0x33, 0x31}, // channel = 13, Tf = 2472MHz
-    {0x06, 0x66, 0x61}, // channel = 14, Tf = 2484MHz
-
-    // 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-    {0x1D, 0x55, 0x51}, // channel = 183, Tf = 4915MHz (15)
-    {0x00, 0x00, 0x01}, // channel = 184, Tf = 4920MHz (16)
-    {0x02, 0xAA, 0xA1}, // channel = 185, Tf = 4925MHz (17)
-    {0x08, 0x00, 0x01}, // channel = 187, Tf = 4935MHz (18)
-    {0x0A, 0xAA, 0xA1}, // channel = 188, Tf = 4940MHz (19)
-    {0x0D, 0x55, 0x51}, // channel = 189, Tf = 4945MHz (20)
-    {0x15, 0x55, 0x51}, // channel = 192, Tf = 4960MHz (21)
-    {0x00, 0x00, 0x01}, // channel = 196, Tf = 4980MHz (22)
-
-    // 5G => Ch 7, 8, 9, 11, 12, 16, 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64,
-    // 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 149, 153, 157, 161, 165  (Value 23 ~ 56)
-    {0x1D, 0x55, 0x51}, // channel =   7, Tf = 5035MHz (23)
-    {0x00, 0x00, 0x01}, // channel =   8, Tf = 5040MHz (24)
-    {0x02, 0xAA, 0xA1}, // channel =   9, Tf = 5045MHz (25)
-    {0x08, 0x00, 0x01}, // channel =  11, Tf = 5055MHz (26)
-    {0x0A, 0xAA, 0xA1}, // channel =  12, Tf = 5060MHz (27)
-    {0x15, 0x55, 0x51}, // channel =  16, Tf = 5080MHz (28)
-    {0x05, 0x55, 0x51}, // channel =  34, Tf = 5170MHz (29)
-    {0x0A, 0xAA, 0xA1}, // channel =  36, Tf = 5180MHz (30)
-    {0x10, 0x00, 0x01}, // channel =  38, Tf = 5190MHz (31)
-    {0x15, 0x55, 0x51}, // channel =  40, Tf = 5200MHz (32)
-    {0x1A, 0xAA, 0xA1}, // channel =  42, Tf = 5210MHz (33)
-    {0x00, 0x00, 0x01}, // channel =  44, Tf = 5220MHz (34)
-    {0x05, 0x55, 0x51}, // channel =  46, Tf = 5230MHz (35)
-    {0x0A, 0xAA, 0xA1}, // channel =  48, Tf = 5240MHz (36)
-    {0x15, 0x55, 0x51}, // channel =  52, Tf = 5260MHz (37)
-    {0x00, 0x00, 0x01}, // channel =  56, Tf = 5280MHz (38)
-    {0x0A, 0xAA, 0xA1}, // channel =  60, Tf = 5300MHz (39)
-    {0x15, 0x55, 0x51}, // channel =  64, Tf = 5320MHz (40)
-    {0x15, 0x55, 0x51}, // channel = 100, Tf = 5500MHz (41)
-    {0x00, 0x00, 0x01}, // channel = 104, Tf = 5520MHz (42)
-    {0x0A, 0xAA, 0xA1}, // channel = 108, Tf = 5540MHz (43)
-    {0x15, 0x55, 0x51}, // channel = 112, Tf = 5560MHz (44)
-    {0x00, 0x00, 0x01}, // channel = 116, Tf = 5580MHz (45)
-    {0x0A, 0xAA, 0xA1}, // channel = 120, Tf = 5600MHz (46)
-    {0x15, 0x55, 0x51}, // channel = 124, Tf = 5620MHz (47)
-    {0x00, 0x00, 0x01}, // channel = 128, Tf = 5640MHz (48)
-    {0x0A, 0xAA, 0xA1}, // channel = 132, Tf = 5660MHz (49)
-    {0x15, 0x55, 0x51}, // channel = 136, Tf = 5680MHz (50)
-    {0x00, 0x00, 0x01}, // channel = 140, Tf = 5700MHz (51)
-    {0x18, 0x00, 0x01}, // channel = 149, Tf = 5745MHz (52)
-    {0x02, 0xAA, 0xA1}, // channel = 153, Tf = 5765MHz (53)
-    {0x0D, 0x55, 0x51}, // channel = 157, Tf = 5785MHz (54)
-    {0x18, 0x00, 0x01}, // channel = 161, Tf = 5805MHz (55)
-    {0x02, 0xAA, 0xB1}  // channel = 165, Tf = 5825MHz (56)
-    };
+	{0x13, 0x33, 0x31},
+	{0x1b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x13, 0x33, 0x31},
+	{0x1b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x13, 0x33, 0x31},
+	{0x1b, 0x33, 0x31},
+	{0x03, 0x33, 0x31},
+	{0x0b, 0x33, 0x31},
+	{0x13, 0x33, 0x31},
+	{0x06, 0x66, 0x61},
+	{0x1d, 0x55, 0x51}, /* channel = 15, Tf = 4915MHz */
+	{0x00, 0x00, 0x01},
+	{0x02, 0xaa, 0xa1},
+	{0x08, 0x00, 0x01},
+	{0x0a, 0xaa, 0xa1},
+	{0x0d, 0x55, 0x51},
+	{0x15, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x1d, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x02, 0xaa, 0xa1},
+	{0x08, 0x00, 0x01},
+	{0x0a, 0xaa, 0xa1},
+	{0x15, 0x55, 0x51},
+	{0x05, 0x55, 0x51},
+	{0x0a, 0xaa, 0xa1},
+	{0x10, 0x00, 0x01},
+	{0x15, 0x55, 0x51},
+	{0x1a, 0xaa, 0xa1},
+	{0x00, 0x00, 0x01},
+	{0x05, 0x55, 0x51},
+	{0x0a, 0xaa, 0xa1},
+	{0x15, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x0a, 0xaa, 0xa1},
+	{0x15, 0x55, 0x51},
+	{0x15, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x0a, 0xaa, 0xa1},
+	{0x15, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x0a, 0xaa, 0xa1},
+	{0x15, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x0a, 0xaa, 0xa1},
+	{0x15, 0x55, 0x51},
+	{0x00, 0x00, 0x01},
+	{0x18, 0x00, 0x01},
+	{0x02, 0xaa, 0xa1},
+	{0x0d, 0x55, 0x51},
+	{0x18, 0x00, 0x01},
+	{0x02, 0xaa, 0xb1}
+};
 
 static u8 al7230_channel_table2[CB_MAX_CHANNEL][3] = {
-    {0x7F, 0xD7, 0x84}, // channel =  1, Tf = 2412MHz
-    {0x7F, 0xD7, 0x84}, // channel =  2, Tf = 2417MHz
-    {0x7F, 0xD7, 0x84}, // channel =  3, Tf = 2422MHz
-    {0x7F, 0xD7, 0x84}, // channel =  4, Tf = 2427MHz
-    {0x7F, 0xD7, 0x84}, // channel =  5, Tf = 2432MHz
-    {0x7F, 0xD7, 0x84}, // channel =  6, Tf = 2437MHz
-    {0x7F, 0xD7, 0x84}, // channel =  7, Tf = 2442MHz
-    {0x7F, 0xD7, 0x84}, // channel =  8, Tf = 2447MHz
-    {0x7F, 0xD7, 0x84}, // channel =  9, Tf = 2452MHz
-    {0x7F, 0xD7, 0x84}, // channel = 10, Tf = 2457MHz
-    {0x7F, 0xD7, 0x84}, // channel = 11, Tf = 2462MHz
-    {0x7F, 0xD7, 0x84}, // channel = 12, Tf = 2467MHz
-    {0x7F, 0xD7, 0x84}, // channel = 13, Tf = 2472MHz
-    {0x7F, 0xD7, 0x84}, // channel = 14, Tf = 2484MHz
-
-    // 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-    {0x7F, 0xD7, 0x84}, // channel = 183, Tf = 4915MHz (15)
-    {0x6F, 0xD7, 0x84}, // channel = 184, Tf = 4920MHz (16)
-    {0x7F, 0xD7, 0x84}, // channel = 185, Tf = 4925MHz (17)
-    {0x7F, 0xD7, 0x84}, // channel = 187, Tf = 4935MHz (18)
-    {0x7F, 0xD7, 0x84}, // channel = 188, Tf = 4940MHz (19)
-    {0x7F, 0xD7, 0x84}, // channel = 189, Tf = 4945MHz (20)
-    {0x7F, 0xD7, 0x84}, // channel = 192, Tf = 4960MHz (21)
-    {0x6F, 0xD7, 0x84}, // channel = 196, Tf = 4980MHz (22)
-
-    // 5G => Ch 7, 8, 9, 11, 12, 16, 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64,
-    // 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 149, 153, 157, 161, 165  (Value 23 ~ 56)
-    {0x7F, 0xD7, 0x84}, // channel =   7, Tf = 5035MHz (23)
-    {0x6F, 0xD7, 0x84}, // channel =   8, Tf = 5040MHz (24)
-    {0x7F, 0xD7, 0x84}, // channel =   9, Tf = 5045MHz (25)
-    {0x7F, 0xD7, 0x84}, // channel =  11, Tf = 5055MHz (26)
-    {0x7F, 0xD7, 0x84}, // channel =  12, Tf = 5060MHz (27)
-    {0x7F, 0xD7, 0x84}, // channel =  16, Tf = 5080MHz (28)
-    {0x7F, 0xD7, 0x84}, // channel =  34, Tf = 5170MHz (29)
-    {0x7F, 0xD7, 0x84}, // channel =  36, Tf = 5180MHz (30)
-    {0x7F, 0xD7, 0x84}, // channel =  38, Tf = 5190MHz (31)
-    {0x7F, 0xD7, 0x84}, // channel =  40, Tf = 5200MHz (32)
-    {0x7F, 0xD7, 0x84}, // channel =  42, Tf = 5210MHz (33)
-    {0x6F, 0xD7, 0x84}, // channel =  44, Tf = 5220MHz (34)
-    {0x7F, 0xD7, 0x84}, // channel =  46, Tf = 5230MHz (35)
-    {0x7F, 0xD7, 0x84}, // channel =  48, Tf = 5240MHz (36)
-    {0x7F, 0xD7, 0x84}, // channel =  52, Tf = 5260MHz (37)
-    {0x6F, 0xD7, 0x84}, // channel =  56, Tf = 5280MHz (38)
-    {0x7F, 0xD7, 0x84}, // channel =  60, Tf = 5300MHz (39)
-    {0x7F, 0xD7, 0x84}, // channel =  64, Tf = 5320MHz (40)
-    {0x7F, 0xD7, 0x84}, // channel = 100, Tf = 5500MHz (41)
-    {0x6F, 0xD7, 0x84}, // channel = 104, Tf = 5520MHz (42)
-    {0x7F, 0xD7, 0x84}, // channel = 108, Tf = 5540MHz (43)
-    {0x7F, 0xD7, 0x84}, // channel = 112, Tf = 5560MHz (44)
-    {0x6F, 0xD7, 0x84}, // channel = 116, Tf = 5580MHz (45)
-    {0x7F, 0xD7, 0x84}, // channel = 120, Tf = 5600MHz (46)
-    {0x7F, 0xD7, 0x84}, // channel = 124, Tf = 5620MHz (47)
-    {0x6F, 0xD7, 0x84}, // channel = 128, Tf = 5640MHz (48)
-    {0x7F, 0xD7, 0x84}, // channel = 132, Tf = 5660MHz (49)
-    {0x7F, 0xD7, 0x84}, // channel = 136, Tf = 5680MHz (50)
-    {0x6F, 0xD7, 0x84}, // channel = 140, Tf = 5700MHz (51)
-    {0x7F, 0xD7, 0x84}, // channel = 149, Tf = 5745MHz (52)
-    {0x7F, 0xD7, 0x84}, // channel = 153, Tf = 5765MHz (53)
-    {0x7F, 0xD7, 0x84}, // channel = 157, Tf = 5785MHz (54)
-    {0x7F, 0xD7, 0x84}, // channel = 161, Tf = 5805MHz (55)
-    {0x7F, 0xD7, 0x84}  // channel = 165, Tf = 5825MHz (56)
-    };
-
-///{{RobertYu:20051111
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84}, /* channel = 15 Tf = 4915MHz */
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x6f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84},
+	{0x7f, 0xd7, 0x84}
+};
+
 static u8 vt3226_init_table[CB_VT3226_INIT_SEQ][3] = {
-    {0x03, 0xFF, 0x80},
-    {0x02, 0x82, 0xA1},
-    {0x03, 0xC6, 0xA2},
-    {0x01, 0x97, 0x93},
-    {0x03, 0x66, 0x64},
-    {0x00, 0x61, 0xA5},
-    {0x01, 0x7B, 0xD6},
-    {0x00, 0x80, 0x17},
-    {0x03, 0xF8, 0x08},
-    {0x00, 0x02, 0x39},   //RobertYu:20051116
-    {0x02, 0x00, 0x2A}
-    };
+	{0x03, 0xff, 0x80},
+	{0x02, 0x82, 0xa1},
+	{0x03, 0xc6, 0xa2},
+	{0x01, 0x97, 0x93},
+	{0x03, 0x66, 0x64},
+	{0x00, 0x61, 0xa5},
+	{0x01, 0x7b, 0xd6},
+	{0x00, 0x80, 0x17},
+	{0x03, 0xf8, 0x08},
+	{0x00, 0x02, 0x39},
+	{0x02, 0x00, 0x2a}
+};
 
 static u8 vt3226d0_init_table[CB_VT3226_INIT_SEQ][3] = {
-    {0x03, 0xFF, 0x80},
-    {0x03, 0x02, 0x21}, //RobertYu:20060327
-    {0x03, 0xC6, 0xA2},
-    {0x01, 0x97, 0x93},
-    {0x03, 0x66, 0x64},
-    {0x00, 0x71, 0xA5}, //RobertYu:20060103
-    {0x01, 0x15, 0xC6}, //RobertYu:20060420
-    {0x01, 0x2E, 0x07}, //RobertYu:20060420
-    {0x00, 0x58, 0x08}, //RobertYu:20060111
-    {0x00, 0x02, 0x79}, //RobertYu:20060420
-    {0x02, 0x01, 0xAA}  //RobertYu:20060523
-    };
+	{0x03, 0xff, 0x80},
+	{0x03, 0x02, 0x21},
+	{0x03, 0xc6, 0xa2},
+	{0x01, 0x97, 0x93},
+	{0x03, 0x66, 0x64},
+	{0x00, 0x71, 0xa5},
+	{0x01, 0x15, 0xc6},
+	{0x01, 0x2e, 0x07},
+	{0x00, 0x58, 0x08},
+	{0x00, 0x02, 0x79},
+	{0x02, 0x01, 0xaa}
+};
 
 static u8 vt3226_channel_table0[CB_MAX_CHANNEL_24G][3] = {
-    {0x01, 0x97, 0x83}, // channel = 1, Tf = 2412MHz
-    {0x01, 0x97, 0x83}, // channel = 2, Tf = 2417MHz
-    {0x01, 0x97, 0x93}, // channel = 3, Tf = 2422MHz
-    {0x01, 0x97, 0x93}, // channel = 4, Tf = 2427MHz
-    {0x01, 0x97, 0x93}, // channel = 5, Tf = 2432MHz
-    {0x01, 0x97, 0x93}, // channel = 6, Tf = 2437MHz
-    {0x01, 0x97, 0xA3}, // channel = 7, Tf = 2442MHz
-    {0x01, 0x97, 0xA3}, // channel = 8, Tf = 2447MHz
-    {0x01, 0x97, 0xA3}, // channel = 9, Tf = 2452MHz
-    {0x01, 0x97, 0xA3}, // channel = 10, Tf = 2457MHz
-    {0x01, 0x97, 0xB3}, // channel = 11, Tf = 2462MHz
-    {0x01, 0x97, 0xB3}, // channel = 12, Tf = 2467MHz
-    {0x01, 0x97, 0xB3}, // channel = 13, Tf = 2472MHz
-    {0x03, 0x37, 0xC3}  // channel = 14, Tf = 2484MHz
-    };
+	{0x01, 0x97, 0x83},
+	{0x01, 0x97, 0x83},
+	{0x01, 0x97, 0x93},
+	{0x01, 0x97, 0x93},
+	{0x01, 0x97, 0x93},
+	{0x01, 0x97, 0x93},
+	{0x01, 0x97, 0xa3},
+	{0x01, 0x97, 0xa3},
+	{0x01, 0x97, 0xa3},
+	{0x01, 0x97, 0xa3},
+	{0x01, 0x97, 0xb3},
+	{0x01, 0x97, 0xb3},
+	{0x01, 0x97, 0xb3},
+	{0x03, 0x37, 0xc3}
+};
 
 static u8 vt3226_channel_table1[CB_MAX_CHANNEL_24G][3] = {
-    {0x02, 0x66, 0x64}, // channel = 1, Tf = 2412MHz
-    {0x03, 0x66, 0x64}, // channel = 2, Tf = 2417MHz
-    {0x00, 0x66, 0x64}, // channel = 3, Tf = 2422MHz
-    {0x01, 0x66, 0x64}, // channel = 4, Tf = 2427MHz
-    {0x02, 0x66, 0x64}, // channel = 5, Tf = 2432MHz
-    {0x03, 0x66, 0x64}, // channel = 6, Tf = 2437MHz
-    {0x00, 0x66, 0x64}, // channel = 7, Tf = 2442MHz
-    {0x01, 0x66, 0x64}, // channel = 8, Tf = 2447MHz
-    {0x02, 0x66, 0x64}, // channel = 9, Tf = 2452MHz
-    {0x03, 0x66, 0x64}, // channel = 10, Tf = 2457MHz
-    {0x00, 0x66, 0x64}, // channel = 11, Tf = 2462MHz
-    {0x01, 0x66, 0x64}, // channel = 12, Tf = 2467MHz
-    {0x02, 0x66, 0x64}, // channel = 13, Tf = 2472MHz
-    {0x00, 0xCC, 0xC4}  // channel = 14, Tf = 2484MHz
-    };
-///}}RobertYu
-
-//{{RobertYu:20060502, TWIF 1.14, LO Current for 11b mode
+	{0x02, 0x66, 0x64},
+	{0x03, 0x66, 0x64},
+	{0x00, 0x66, 0x64},
+	{0x01, 0x66, 0x64},
+	{0x02, 0x66, 0x64},
+	{0x03, 0x66, 0x64},
+	{0x00, 0x66, 0x64},
+	{0x01, 0x66, 0x64},
+	{0x02, 0x66, 0x64},
+	{0x03, 0x66, 0x64},
+	{0x00, 0x66, 0x64},
+	{0x01, 0x66, 0x64},
+	{0x02, 0x66, 0x64},
+	{0x00, 0xcc, 0xc4}
+};
+
 static const u32 vt3226d0_lo_current_table[CB_MAX_CHANNEL_24G] = {
-    0x0135C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 1, Tf = 2412MHz
-    0x0135C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 2, Tf = 2417MHz
-    0x0235C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 3, Tf = 2422MHz
-    0x0235C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 4, Tf = 2427MHz
-    0x0235C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 5, Tf = 2432MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 6, Tf = 2437MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 7, Tf = 2442MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 8, Tf = 2447MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 9, Tf = 2452MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 10, Tf = 2457MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 11, Tf = 2462MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 12, Tf = 2467MHz
-    0x0335C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW, // channel = 13, Tf = 2472MHz
-    0x0135C600+(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW  // channel = 14, Tf = 2484MHz
+	0x0135c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0135c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0235c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0235c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0235c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0135c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW
 };
-//}}
 
-//{{RobertYu:20060609
 static u8 vt3342a0_init_table[CB_VT3342_INIT_SEQ][3] = { /* 11b/g mode */
-    {0x03, 0xFF, 0x80}, //update for mode//
-    {0x02, 0x08, 0x81},
-    {0x00, 0xC6, 0x02},
-    {0x03, 0xC5, 0x13}, // channel6
-    {0x00, 0xEE, 0xE4}, // channel6
-    {0x00, 0x71, 0xA5},
-    {0x01, 0x75, 0x46},
-    {0x01, 0x40, 0x27},
-    {0x01, 0x54, 0x08},
-    {0x00, 0x01, 0x69},
-    {0x02, 0x00, 0xAA},
-    {0x00, 0x08, 0xCB},
-    {0x01, 0x70, 0x0C}
-    };
-
- //11b/g mode: 0x03, 0xFF, 0x80,
- //11a mode:   0x03, 0xFF, 0xC0,
-
- // channel44, 5220MHz  0x00C402
- // channel56, 5280MHz  0x00C402 for disable Frac
- // other channels 0x00C602
+	{0x03, 0xff, 0x80},
+	{0x02, 0x08, 0x81},
+	{0x00, 0xc6, 0x02},
+	{0x03, 0xc5, 0x13},
+	{0x00, 0xee, 0xe4},
+	{0x00, 0x71, 0xa5},
+	{0x01, 0x75, 0x46},
+	{0x01, 0x40, 0x27},
+	{0x01, 0x54, 0x08},
+	{0x00, 0x01, 0x69},
+	{0x02, 0x00, 0xaa},
+	{0x00, 0x08, 0xcb},
+	{0x01, 0x70, 0x0c}
+};
 
 static u8 vt3342_channel_table0[CB_MAX_CHANNEL][3] = {
-    {0x02, 0x05, 0x03}, // channel = 1, Tf = 2412MHz
-    {0x01, 0x15, 0x03}, // channel = 2, Tf = 2417MHz
-    {0x03, 0xC5, 0x03}, // channel = 3, Tf = 2422MHz
-    {0x02, 0x65, 0x03}, // channel = 4, Tf = 2427MHz
-    {0x01, 0x15, 0x13}, // channel = 5, Tf = 2432MHz
-    {0x03, 0xC5, 0x13}, // channel = 6, Tf = 2437MHz
-    {0x02, 0x05, 0x13}, // channel = 7, Tf = 2442MHz
-    {0x01, 0x15, 0x13}, // channel = 8, Tf = 2447MHz
-    {0x03, 0xC5, 0x13}, // channel = 9, Tf = 2452MHz
-    {0x02, 0x65, 0x13}, // channel = 10, Tf = 2457MHz
-    {0x01, 0x15, 0x23}, // channel = 11, Tf = 2462MHz
-    {0x03, 0xC5, 0x23}, // channel = 12, Tf = 2467MHz
-    {0x02, 0x05, 0x23}, // channel = 13, Tf = 2472MHz
-    {0x00, 0xD5, 0x23}, // channel = 14, Tf = 2484MHz
-
-    // 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-    {0x01, 0x15, 0x13}, // channel = 183, Tf = 4915MHz (15), TBD
-    {0x01, 0x15, 0x13}, // channel = 184, Tf = 4920MHz (16), TBD
-    {0x01, 0x15, 0x13}, // channel = 185, Tf = 4925MHz (17), TBD
-    {0x01, 0x15, 0x13}, // channel = 187, Tf = 4935MHz (18), TBD
-    {0x01, 0x15, 0x13}, // channel = 188, Tf = 4940MHz (19), TBD
-    {0x01, 0x15, 0x13}, // channel = 189, Tf = 4945MHz (20), TBD
-    {0x01, 0x15, 0x13}, // channel = 192, Tf = 4960MHz (21), TBD
-    {0x01, 0x15, 0x13}, // channel = 196, Tf = 4980MHz (22), TBD
-
-    // 5G => Ch 7, 8, 9, 11, 12, 16, 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64,
-    // 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 149, 153, 157, 161, 165  (Value 23 ~ 56)
-    {0x01, 0x15, 0x13}, // channel =   7, Tf = 5035MHz (23), TBD
-    {0x01, 0x15, 0x13}, // channel =   8, Tf = 5040MHz (24), TBD
-    {0x01, 0x15, 0x13}, // channel =   9, Tf = 5045MHz (25), TBD
-    {0x01, 0x15, 0x13}, // channel =  11, Tf = 5055MHz (26), TBD
-    {0x01, 0x15, 0x13}, // channel =  12, Tf = 5060MHz (27), TBD
-    {0x01, 0x15, 0x13}, // channel =  16, Tf = 5080MHz (28), TBD
-    {0x01, 0x15, 0x13}, // channel =  34, Tf = 5170MHz (29), TBD
-    {0x01, 0x55, 0x63}, // channel =  36, Tf = 5180MHz (30)
-    {0x01, 0x55, 0x63}, // channel =  38, Tf = 5190MHz (31), TBD
-    {0x02, 0xA5, 0x63}, // channel =  40, Tf = 5200MHz (32)
-    {0x02, 0xA5, 0x63}, // channel =  42, Tf = 5210MHz (33), TBD
-    {0x00, 0x05, 0x73}, // channel =  44, Tf = 5220MHz (34)
-    {0x00, 0x05, 0x73}, // channel =  46, Tf = 5230MHz (35), TBD
-    {0x01, 0x55, 0x73}, // channel =  48, Tf = 5240MHz (36)
-    {0x02, 0xA5, 0x73}, // channel =  52, Tf = 5260MHz (37)
-    {0x00, 0x05, 0x83}, // channel =  56, Tf = 5280MHz (38)
-    {0x01, 0x55, 0x83}, // channel =  60, Tf = 5300MHz (39)
-    {0x02, 0xA5, 0x83}, // channel =  64, Tf = 5320MHz (40)
-
-    {0x02, 0xA5, 0x83}, // channel = 100, Tf = 5500MHz (41), TBD
-    {0x02, 0xA5, 0x83}, // channel = 104, Tf = 5520MHz (42), TBD
-    {0x02, 0xA5, 0x83}, // channel = 108, Tf = 5540MHz (43), TBD
-    {0x02, 0xA5, 0x83}, // channel = 112, Tf = 5560MHz (44), TBD
-    {0x02, 0xA5, 0x83}, // channel = 116, Tf = 5580MHz (45), TBD
-    {0x02, 0xA5, 0x83}, // channel = 120, Tf = 5600MHz (46), TBD
-    {0x02, 0xA5, 0x83}, // channel = 124, Tf = 5620MHz (47), TBD
-    {0x02, 0xA5, 0x83}, // channel = 128, Tf = 5640MHz (48), TBD
-    {0x02, 0xA5, 0x83}, // channel = 132, Tf = 5660MHz (49), TBD
-    {0x02, 0xA5, 0x83}, // channel = 136, Tf = 5680MHz (50), TBD
-    {0x02, 0xA5, 0x83}, // channel = 140, Tf = 5700MHz (51), TBD
-
-    {0x00, 0x05, 0xF3}, // channel = 149, Tf = 5745MHz (52)
-    {0x01, 0x56, 0x03}, // channel = 153, Tf = 5765MHz (53)
-    {0x02, 0xA6, 0x03}, // channel = 157, Tf = 5785MHz (54)
-    {0x00, 0x06, 0x03}, // channel = 161, Tf = 5805MHz (55)
-    {0x00, 0x06, 0x03}  // channel = 165, Tf = 5825MHz (56), TBD
-    };
+	{0x02, 0x05, 0x03},
+	{0x01, 0x15, 0x03},
+	{0x03, 0xc5, 0x03},
+	{0x02, 0x65, 0x03},
+	{0x01, 0x15, 0x13},
+	{0x03, 0xc5, 0x13},
+	{0x02, 0x05, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x03, 0xc5, 0x13},
+	{0x02, 0x65, 0x13},
+	{0x01, 0x15, 0x23},
+	{0x03, 0xc5, 0x23},
+	{0x02, 0x05, 0x23},
+	{0x00, 0xd5, 0x23},
+	{0x01, 0x15, 0x13}, /* channel = 15 Tf = 4915MHz */
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x15, 0x13},
+	{0x01, 0x55, 0x63},
+	{0x01, 0x55, 0x63},
+	{0x02, 0xa5, 0x63},
+	{0x02, 0xa5, 0x63},
+	{0x00, 0x05, 0x73},
+	{0x00, 0x05, 0x73},
+	{0x01, 0x55, 0x73},
+	{0x02, 0xa5, 0x73},
+	{0x00, 0x05, 0x83},
+	{0x01, 0x55, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x02, 0xa5, 0x83},
+	{0x00, 0x05, 0xF3},
+	{0x01, 0x56, 0x03},
+	{0x02, 0xa6, 0x03},
+	{0x00, 0x06, 0x03},
+	{0x00, 0x06, 0x03}
+};
 
 static u8 vt3342_channel_table1[CB_MAX_CHANNEL][3] = {
-    {0x01, 0x99, 0x94}, // channel = 1, Tf = 2412MHz
-    {0x02, 0x44, 0x44}, // channel = 2, Tf = 2417MHz
-    {0x02, 0xEE, 0xE4}, // channel = 3, Tf = 2422MHz
-    {0x03, 0x99, 0x94}, // channel = 4, Tf = 2427MHz
-    {0x00, 0x44, 0x44}, // channel = 5, Tf = 2432MHz
-    {0x00, 0xEE, 0xE4}, // channel = 6, Tf = 2437MHz
-    {0x01, 0x99, 0x94}, // channel = 7, Tf = 2442MHz
-    {0x02, 0x44, 0x44}, // channel = 8, Tf = 2447MHz
-    {0x02, 0xEE, 0xE4}, // channel = 9, Tf = 2452MHz
-    {0x03, 0x99, 0x94}, // channel = 10, Tf = 2457MHz
-    {0x00, 0x44, 0x44}, // channel = 11, Tf = 2462MHz
-    {0x00, 0xEE, 0xE4}, // channel = 12, Tf = 2467MHz
-    {0x01, 0x99, 0x94}, // channel = 13, Tf = 2472MHz
-    {0x03, 0x33, 0x34}, // channel = 14, Tf = 2484MHz
-
-    // 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-    {0x00, 0x44, 0x44}, // channel = 183, Tf = 4915MHz (15), TBD
-    {0x00, 0x44, 0x44}, // channel = 184, Tf = 4920MHz (16), TBD
-    {0x00, 0x44, 0x44}, // channel = 185, Tf = 4925MHz (17), TBD
-    {0x00, 0x44, 0x44}, // channel = 187, Tf = 4935MHz (18), TBD
-    {0x00, 0x44, 0x44}, // channel = 188, Tf = 4940MHz (19), TBD
-    {0x00, 0x44, 0x44}, // channel = 189, Tf = 4945MHz (20), TBD
-    {0x00, 0x44, 0x44}, // channel = 192, Tf = 4960MHz (21), TBD
-    {0x00, 0x44, 0x44}, // channel = 196, Tf = 4980MHz (22), TBD
-
-    // 5G => Ch 7, 8, 9, 11, 12, 16, 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64,
-    // 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 149, 153, 157, 161, 165  (Value 23 ~ 56)
-    {0x00, 0x44, 0x44}, // channel =   7, Tf = 5035MHz (23), TBD
-    {0x00, 0x44, 0x44}, // channel =   8, Tf = 5040MHz (24), TBD
-    {0x00, 0x44, 0x44}, // channel =   9, Tf = 5045MHz (25), TBD
-    {0x00, 0x44, 0x44}, // channel =  11, Tf = 5055MHz (26), TBD
-    {0x00, 0x44, 0x44}, // channel =  12, Tf = 5060MHz (27), TBD
-    {0x00, 0x44, 0x44}, // channel =  16, Tf = 5080MHz (28), TBD
-    {0x00, 0x44, 0x44}, // channel =  34, Tf = 5170MHz (29), TBD
-    {0x01, 0x55, 0x54}, // channel =  36, Tf = 5180MHz (30)
-    {0x01, 0x55, 0x54}, // channel =  38, Tf = 5190MHz (31), TBD
-    {0x02, 0xAA, 0xA4}, // channel =  40, Tf = 5200MHz (32)
-    {0x02, 0xAA, 0xA4}, // channel =  42, Tf = 5210MHz (33), TBD
-    {0x00, 0x00, 0x04}, // channel =  44, Tf = 5220MHz (34)
-    {0x00, 0x00, 0x04}, // channel =  46, Tf = 5230MHz (35), TBD
-    {0x01, 0x55, 0x54}, // channel =  48, Tf = 5240MHz (36)
-    {0x02, 0xAA, 0xA4}, // channel =  52, Tf = 5260MHz (37)
-    {0x00, 0x00, 0x04}, // channel =  56, Tf = 5280MHz (38)
-    {0x01, 0x55, 0x54}, // channel =  60, Tf = 5300MHz (39)
-    {0x02, 0xAA, 0xA4}, // channel =  64, Tf = 5320MHz (40)
-    {0x02, 0xAA, 0xA4}, // channel = 100, Tf = 5500MHz (41), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 104, Tf = 5520MHz (42), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 108, Tf = 5540MHz (43), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 112, Tf = 5560MHz (44), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 116, Tf = 5580MHz (45), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 120, Tf = 5600MHz (46), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 124, Tf = 5620MHz (47), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 128, Tf = 5640MHz (48), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 132, Tf = 5660MHz (49), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 136, Tf = 5680MHz (50), TBD
-    {0x02, 0xAA, 0xA4}, // channel = 140, Tf = 5700MHz (51), TBD
-    {0x03, 0x00, 0x04}, // channel = 149, Tf = 5745MHz (52)
-    {0x00, 0x55, 0x54}, // channel = 153, Tf = 5765MHz (53)
-    {0x01, 0xAA, 0xA4}, // channel = 157, Tf = 5785MHz (54)
-    {0x03, 0x00, 0x04}, // channel = 161, Tf = 5805MHz (55)
-    {0x03, 0x00, 0x04}  // channel = 165, Tf = 5825MHz (56), TBD
-    };
+	{0x01, 0x99, 0x94},
+	{0x02, 0x44, 0x44},
+	{0x02, 0xee, 0xe4},
+	{0x03, 0x99, 0x94},
+	{0x00, 0x44, 0x44},
+	{0x00, 0xee, 0xe4},
+	{0x01, 0x99, 0x94},
+	{0x02, 0x44, 0x44},
+	{0x02, 0xee, 0xe4},
+	{0x03, 0x99, 0x94},
+	{0x00, 0x44, 0x44},
+	{0x00, 0xee, 0xe4},
+	{0x01, 0x99, 0x94},
+	{0x03, 0x33, 0x34},
+	{0x00, 0x44, 0x44}, /* channel = 15 Tf = 4915MHz */
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x00, 0x44, 0x44},
+	{0x01, 0x55, 0x54},
+	{0x01, 0x55, 0x54},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x00, 0x00, 0x04},
+	{0x00, 0x00, 0x04},
+	{0x01, 0x55, 0x54},
+	{0x02, 0xaa, 0xa4},
+	{0x00, 0x00, 0x04},
+	{0x01, 0x55, 0x54},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x02, 0xaa, 0xa4},
+	{0x03, 0x00, 0x04},
+	{0x00, 0x55, 0x54},
+	{0x01, 0xaa, 0xa4},
+	{0x03, 0x00, 0x04},
+	{0x03, 0x00, 0x04}
+};
 
 /*+
  *
@@ -594,71 +547,71 @@ static u8 vt3342_channel_table1[CB_MAX_CHANNEL][3] = {
 -*/
 
 static const u32 al2230_power_table[AL2230_PWR_IDX_LEN] = {
-    0x04040900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04041900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04042900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04043900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04044900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04045900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04046900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04047900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04048900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04049900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0404A900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0404B900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0404C900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0404D900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0404E900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0404F900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04050900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04051900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04052900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04053900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04054900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04055900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04056900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04057900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04058900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04059900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0405A900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0405B900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0405C900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0405D900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0405E900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0405F900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04060900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04061900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04062900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04063900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04064900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04065900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04066900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04067900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04068900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04069900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0406A900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0406B900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0406C900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0406D900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0406E900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0406F900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04070900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04071900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04072900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04073900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04074900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04075900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04076900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04077900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04078900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x04079900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0407A900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0407B900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0407C900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0407D900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0407E900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW,
-    0x0407F900+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW
-    };
+	0x04040900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04041900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04042900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04043900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04044900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04045900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04046900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04047900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04048900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04049900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0404a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0404b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0404c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0404d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0404e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0404f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04050900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04051900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04052900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04053900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04054900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04055900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04056900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04057900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04058900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04059900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0405a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0405b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0405c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0405d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0405e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0405f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04060900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04061900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04062900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04063900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04064900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04065900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04066900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04067900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04068900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04069900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0406a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0406b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0406c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0406d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0406e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0406f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04070900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04071900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04072900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04073900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04074900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04075900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04076900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04077900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04078900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x04079900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0407a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0407b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0407c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0407d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0407e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
+	0x0407f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW
+};
 
 //{{ RobertYu:20050103, Channel 11a Number To Index
 // 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/4] staging: vt6656: rf.c remove dead code RFaby11aChannelIndex
  2014-07-12 10:30 [PATCH 1/4] staging: vt6656: rf.c clean up channel and power tables Malcolm Priestley
@ 2014-07-12 10:30 ` Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 3/4] staging: vt6656: vnt_rf_write_embedded add reg length and IFREGCTL_REGW Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 4/4] staging: vt6656: rf.c cleanup comments Malcolm Priestley
  2 siblings, 0 replies; 4+ messages in thread
From: Malcolm Priestley @ 2014-07-12 10:30 UTC (permalink / raw)
  To: gregkh; +Cc: linux-wireless, Malcolm Priestley

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6656/rf.c | 31 -------------------------------
 drivers/staging/vt6656/rf.h |  2 --
 2 files changed, 33 deletions(-)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index f203dde..1661f8ee 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -613,37 +613,6 @@ static const u32 al2230_power_table[AL2230_PWR_IDX_LEN] = {
 	0x0407f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW
 };
 
-//{{ RobertYu:20050103, Channel 11a Number To Index
-// 4.9G => Ch 183, 184, 185, 187, 188, 189, 192, 196  (Value:15 ~ 22)
-// 5G => Ch 7, 8, 9, 11, 12, 16, 34, 36, 38, 40, 42, 44, 46, 48, 52, 56, 60, 64,
-// 100, 104, 108, 112, 116, 120, 124, 128, 132, 136, 140, 149, 153, 157, 161, 165  (Value 23 ~ 56)
-
-const u8 RFaby11aChannelIndex[200] = {
-  // 1   2   3   4   5   6   7   8   9  10
-    00, 00, 00, 00, 00, 00, 23, 24, 25, 00,  // 10
-    26, 27, 00, 00, 00, 28, 00, 00, 00, 00,  // 20
-    00, 00, 00, 00, 00, 00, 00, 00, 00, 00,  // 30
-    00, 00, 00, 29, 00, 30, 00, 31, 00, 32,  // 40
-    00, 33, 00, 34, 00, 35, 00, 36, 00, 00,  // 50
-    00, 37, 00, 00, 00, 38, 00, 00, 00, 39,  // 60
-    00, 00, 00, 40, 00, 00, 00, 00, 00, 00,  // 70
-    00, 00, 00, 00, 00, 00, 00, 00, 00, 00,  // 80
-    00, 00, 00, 00, 00, 00, 00, 00, 00, 00,  // 90
-    00, 00, 00, 00, 00, 00, 00, 00, 00, 41,  //100
-
-    00, 00, 00, 42, 00, 00, 00, 43, 00, 00,  //110
-    00, 44, 00, 00, 00, 45, 00, 00, 00, 46,  //120
-    00, 00, 00, 47, 00, 00, 00, 48, 00, 00,  //130
-    00, 49, 00, 00, 00, 50, 00, 00, 00, 51,  //140
-    00, 00, 00, 00, 00, 00, 00, 00, 52, 00,  //150
-    00, 00, 53, 00, 00, 00, 54, 00, 00, 00,  //160
-    55, 00, 00, 00, 56, 00, 00, 00, 00, 00,  //170
-    00, 00, 00, 00, 00, 00, 00, 00, 00, 00,  //180
-    00, 00, 15, 16, 17, 00, 18, 19, 20, 00,  //190
-    00, 21, 00, 00, 00, 22, 00, 00, 00, 00   //200
-};
-//}} RobertYu
-
 /*
  * Description: Write to IF/RF, by embedded programming
  *
diff --git a/drivers/staging/vt6656/rf.h b/drivers/staging/vt6656/rf.h
index cb33151..d2347b4 100644
--- a/drivers/staging/vt6656/rf.h
+++ b/drivers/staging/vt6656/rf.h
@@ -55,8 +55,6 @@
 
 #define VNT_RF_MAX_POWER    0x3f
 
-extern const u8 RFaby11aChannelIndex[200];
-
 int vnt_rf_write_embedded(struct vnt_private *, u32);
 int vnt_rf_setpower(struct vnt_private *, u32, u32);
 int vnt_rf_set_txpower(struct vnt_private *, u8, u32);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/4] staging: vt6656: vnt_rf_write_embedded add reg length and IFREGCTL_REGW
  2014-07-12 10:30 [PATCH 1/4] staging: vt6656: rf.c clean up channel and power tables Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 2/4] staging: vt6656: rf.c remove dead code RFaby11aChannelIndex Malcolm Priestley
@ 2014-07-12 10:30 ` Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 4/4] staging: vt6656: rf.c cleanup comments Malcolm Priestley
  2 siblings, 0 replies; 4+ messages in thread
From: Malcolm Priestley @ 2014-07-12 10:30 UTC (permalink / raw)
  To: gregkh; +Cc: linux-wireless, Malcolm Priestley

The rf register always have  *_REG_LEN and IFREGCTL_REGW macros added.

*_REG_LEN is always 23(0x17) replace them with VNT_RF_REG_LEN.

Remove *_REG_LEN and IFREGCTL_REGW from tables and vnt_rf_set_txpower and
apply VNT_RF_REG_LEN and IFREGCTL_REGW in vnt_rf_write_embedded

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6656/rf.c | 219 ++++++++++++++++++++------------------------
 drivers/staging/vt6656/rf.h |   1 +
 2 files changed, 99 insertions(+), 121 deletions(-)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 1661f8ee..1c3b3fa 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -40,22 +40,18 @@
 #include "baseband.h"
 #include "usbpipe.h"
 
-#define BY_AL2230_REG_LEN     23 //24bit
 #define CB_AL2230_INIT_SEQ    15
 #define AL2230_PWR_IDX_LEN    64
 
-#define BY_AL7230_REG_LEN     23 //24bit
 #define CB_AL7230_INIT_SEQ    16
 #define AL7230_PWR_IDX_LEN    64
 
 //{{RobertYu:20051111
-#define BY_VT3226_REG_LEN     23
 #define CB_VT3226_INIT_SEQ    11
 #define VT3226_PWR_IDX_LEN    64
 //}}
 
 //{{RobertYu:20060609
-#define BY_VT3342_REG_LEN     23
 #define CB_VT3342_INIT_SEQ    13
 #define VT3342_PWR_IDX_LEN    64
 //}}
@@ -390,20 +386,20 @@ static u8 vt3226_channel_table1[CB_MAX_CHANNEL_24G][3] = {
 };
 
 static const u32 vt3226d0_lo_current_table[CB_MAX_CHANNEL_24G] = {
-	0x0135c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0135c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0235c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0235c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0235c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0335c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0135c600 + (BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW
+	0x0135c600,
+	0x0135c600,
+	0x0235c600,
+	0x0235c600,
+	0x0235c600,
+	0x0335c600,
+	0x0335c600,
+	0x0335c600,
+	0x0335c600,
+	0x0335c600,
+	0x0335c600,
+	0x0335c600,
+	0x0335c600,
+	0x0135c600
 };
 
 static u8 vt3342a0_init_table[CB_VT3342_INIT_SEQ][3] = { /* 11b/g mode */
@@ -547,70 +543,70 @@ static u8 vt3342_channel_table1[CB_MAX_CHANNEL][3] = {
 -*/
 
 static const u32 al2230_power_table[AL2230_PWR_IDX_LEN] = {
-	0x04040900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04041900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04042900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04043900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04044900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04045900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04046900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04047900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04048900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04049900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0404a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0404b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0404c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0404d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0404e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0404f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04050900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04051900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04052900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04053900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04054900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04055900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04056900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04057900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04058900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04059900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0405a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0405b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0405c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0405d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0405e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0405f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04060900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04061900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04062900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04063900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04064900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04065900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04066900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04067900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04068900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04069900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0406a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0406b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0406c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0406d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0406e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0406f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04070900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04071900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04072900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04073900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04074900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04075900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04076900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04077900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04078900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x04079900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0407a900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0407b900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0407c900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0407d900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0407e900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
-	0x0407f900 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW
+	0x04040900,
+	0x04041900,
+	0x04042900,
+	0x04043900,
+	0x04044900,
+	0x04045900,
+	0x04046900,
+	0x04047900,
+	0x04048900,
+	0x04049900,
+	0x0404a900,
+	0x0404b900,
+	0x0404c900,
+	0x0404d900,
+	0x0404e900,
+	0x0404f900,
+	0x04050900,
+	0x04051900,
+	0x04052900,
+	0x04053900,
+	0x04054900,
+	0x04055900,
+	0x04056900,
+	0x04057900,
+	0x04058900,
+	0x04059900,
+	0x0405a900,
+	0x0405b900,
+	0x0405c900,
+	0x0405d900,
+	0x0405e900,
+	0x0405f900,
+	0x04060900,
+	0x04061900,
+	0x04062900,
+	0x04063900,
+	0x04064900,
+	0x04065900,
+	0x04066900,
+	0x04067900,
+	0x04068900,
+	0x04069900,
+	0x0406a900,
+	0x0406b900,
+	0x0406c900,
+	0x0406d900,
+	0x0406e900,
+	0x0406f900,
+	0x04070900,
+	0x04071900,
+	0x04072900,
+	0x04073900,
+	0x04074900,
+	0x04075900,
+	0x04076900,
+	0x04077900,
+	0x04078900,
+	0x04079900,
+	0x0407a900,
+	0x0407b900,
+	0x0407c900,
+	0x0407d900,
+	0x0407e900,
+	0x0407f900
 };
 
 /*
@@ -629,6 +625,8 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
 {
 	u8 reg_data[4];
 
+	data |= (VNT_RF_REG_LEN << 3) | IFREGCTL_REGW;
+
 	reg_data[0] = (u8)data;
 	reg_data[1] = (u8)(data >> 8);
 	reg_data[2] = (u8)(data >> 16);
@@ -752,11 +750,9 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 		ret &= vnt_rf_write_embedded(priv, al2230_power_table[power]);
 
 		if (rate <= RATE_11M)
-			ret &= vnt_rf_write_embedded(priv, 0x0001b400 +
-				(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x0001b400);
 		else
-			ret &= vnt_rf_write_embedded(priv, 0x0005a400 +
-				(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x0005a400);
 		break;
 	case RF_AL2230S:
 		if (power >= AL2230_PWR_IDX_LEN)
@@ -765,25 +761,19 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 		ret &= vnt_rf_write_embedded(priv, al2230_power_table[power]);
 
 		if (rate <= RATE_11M) {
-			ret &= vnt_rf_write_embedded(priv, 0x040c1400 +
-				(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
-			ret &= vnt_rf_write_embedded(priv, 0x00299b00 +
-				(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x040c1400);
+			ret &= vnt_rf_write_embedded(priv, 0x00299b00);
 		} else {
-			ret &= vnt_rf_write_embedded(priv, 0x0005a400 +
-				(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
-			ret &= vnt_rf_write_embedded(priv, 0x00099b00 +
-				(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x0005a400);
+			ret &= vnt_rf_write_embedded(priv, 0x00099b00);
 		}
 		break;
 
 	case RF_AIROHA7230:
 		if (rate <= RATE_11M)
-			ret &= vnt_rf_write_embedded(priv, 0x111bb900 +
-				(BY_AL7230_REG_LEN << 3)+IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x111bb900);
 		else
-			ret &= vnt_rf_write_embedded(priv, 0x221bb900 +
-				(BY_AL7230_REG_LEN << 3)+IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x221bb900);
 
 		if (power >= AL7230_PWR_IDX_LEN)
 			return false;
@@ -792,8 +782,7 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 		* 0x080F1B00 for 3 wire control TxGain(D10)
 		* and 0x31 as TX Gain value
 		*/
-		power_setting = 0x080c0b00 | (power << 12) |
-				(BY_AL7230_REG_LEN << 3) | IFREGCTL_REGW;
+		power_setting = 0x080c0b00 | (power << 12);
 
 		ret &= vnt_rf_write_embedded(priv, power_setting);
 
@@ -802,8 +791,7 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 	case RF_VT3226:
 		if (power >= VT3226_PWR_IDX_LEN)
 			return false;
-		power_setting = ((0x3f - power) << 20) | (0x17 << 8) |
-				(BY_VT3226_REG_LEN << 3) | IFREGCTL_REGW;
+		power_setting = ((0x3f - power) << 20) | (0x17 << 8);
 
 		ret &= vnt_rf_write_embedded(priv, power_setting);
 
@@ -815,13 +803,10 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 		if (rate <= RATE_11M) {
 			u16 hw_value = priv->hw->conf.chandef.chan->hw_value;
 
-			power_setting = ((0x3f - power) << 20) |
-				(0xe07 << 8) | (BY_VT3226_REG_LEN << 3) |
-						IFREGCTL_REGW;
+			power_setting = ((0x3f - power) << 20) | (0xe07 << 8);
 
 			ret &= vnt_rf_write_embedded(priv, power_setting);
-			ret &= vnt_rf_write_embedded(priv, 0x03c6a200 +
-					(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x03c6a200);
 
 			dev_dbg(&priv->usb->dev,
 				"%s 11b channel [%d]\n", __func__, hw_value);
@@ -832,23 +817,17 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 				ret &= vnt_rf_write_embedded(priv,
 					vt3226d0_lo_current_table[hw_value]);
 
-			ret &= vnt_rf_write_embedded(priv, 0x015C0800 +
-				(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x015C0800);
 		} else {
 			dev_dbg(&priv->usb->dev,
 					"@@@@ vnt_rf_set_txpower> 11G mode\n");
 
-			power_setting = ((0x3f - power) << 20) |
-				(0x7 << 8) | (BY_VT3226_REG_LEN << 3) |
-					IFREGCTL_REGW;
+			power_setting = ((0x3f - power) << 20) | (0x7 << 8);
 
 			ret &= vnt_rf_write_embedded(priv, power_setting);
-			ret &= vnt_rf_write_embedded(priv, 0x00C6A200 +
-				(BY_VT3226_REG_LEN << 3) + IFREGCTL_REGW);
-			ret &= vnt_rf_write_embedded(priv, 0x016BC600 +
-					(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW);
-			ret &= vnt_rf_write_embedded(priv, 0x00900800 +
-					(BY_VT3226_REG_LEN<<3)+IFREGCTL_REGW);
+			ret &= vnt_rf_write_embedded(priv, 0x00C6A200);
+			ret &= vnt_rf_write_embedded(priv, 0x016BC600);
+			ret &= vnt_rf_write_embedded(priv, 0x00900800);
 		}
 		break;
 
@@ -856,9 +835,7 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 		if (power >= VT3342_PWR_IDX_LEN)
 			return false;
 
-		power_setting =  ((0x3f - power) << 20) |
-			(0x27 << 8) | (BY_VT3342_REG_LEN << 3) |
-					IFREGCTL_REGW;
+		power_setting =  ((0x3f - power) << 20) | (0x27 << 8);
 
 		ret &= vnt_rf_write_embedded(priv, power_setting);
 
diff --git a/drivers/staging/vt6656/rf.h b/drivers/staging/vt6656/rf.h
index d2347b4..8cebb6a 100644
--- a/drivers/staging/vt6656/rf.h
+++ b/drivers/staging/vt6656/rf.h
@@ -54,6 +54,7 @@
 #define RF_MASK             0x7F
 
 #define VNT_RF_MAX_POWER    0x3f
+#define	VNT_RF_REG_LEN      0x17 /* 24 bit length */
 
 int vnt_rf_write_embedded(struct vnt_private *, u32);
 int vnt_rf_setpower(struct vnt_private *, u32, u32);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 4/4] staging: vt6656: rf.c cleanup comments
  2014-07-12 10:30 [PATCH 1/4] staging: vt6656: rf.c clean up channel and power tables Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 2/4] staging: vt6656: rf.c remove dead code RFaby11aChannelIndex Malcolm Priestley
  2014-07-12 10:30 ` [PATCH 3/4] staging: vt6656: vnt_rf_write_embedded add reg length and IFREGCTL_REGW Malcolm Priestley
@ 2014-07-12 10:30 ` Malcolm Priestley
  2 siblings, 0 replies; 4+ messages in thread
From: Malcolm Priestley @ 2014-07-12 10:30 UTC (permalink / raw)
  To: gregkh; +Cc: linux-wireless, Malcolm Priestley

named comments are already referenced in revision history
in high-level comment.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
---
 drivers/staging/vt6656/rf.c | 65 +++------------------------------------------
 1 file changed, 4 insertions(+), 61 deletions(-)

diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 1c3b3fa..28e64b4 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -46,15 +46,11 @@
 #define CB_AL7230_INIT_SEQ    16
 #define AL7230_PWR_IDX_LEN    64
 
-//{{RobertYu:20051111
 #define CB_VT3226_INIT_SEQ    11
 #define VT3226_PWR_IDX_LEN    64
-//}}
 
-//{{RobertYu:20060609
 #define CB_VT3342_INIT_SEQ    13
 #define VT3342_PWR_IDX_LEN    64
-//}}
 
 static u8 al2230_init_table[CB_AL2230_INIT_SEQ][3] = {
 	{0x03, 0xf7, 0x90},
@@ -536,12 +532,7 @@ static u8 vt3342_channel_table1[CB_MAX_CHANNEL][3] = {
 	{0x03, 0x00, 0x04}
 };
 
-/*+
- *
- * Power Table
- *
--*/
-
+/* Power Table */
 static const u32 al2230_power_table[AL2230_PWR_IDX_LEN] = {
 	0x04040900,
 	0x04041900,
@@ -611,15 +602,6 @@ static const u32 al2230_power_table[AL2230_PWR_IDX_LEN] = {
 
 /*
  * Description: Write to IF/RF, by embedded programming
- *
- * Parameters:
- *  In:
- *      dwData      - data to write
- *  Out:
- *      none
- *
- * Return Value: true if succeeded; false if failed.
- *
  */
 int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
 {
@@ -638,19 +620,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
 	return true;
 }
 
-/*
- * Description: Set Tx power
- *
- * Parameters:
- *  In:
- *      dwIoBase       - I/O base address
- *      dwRFPowerTable - RF Tx Power Setting
- *  Out:
- *      none
- *
- * Return Value: true if succeeded; false if failed.
- *
- */
+/* Set Tx power by rate and channel number */
 int vnt_rf_setpower(struct vnt_private *priv, u32 rate, u32 channel)
 {
 	int ret = true;
@@ -714,20 +684,7 @@ static u8 vnt_rf_addpower(struct vnt_private *priv)
 	return 0;
 }
 
-/*
- * Description: Set Tx power
- *
- * Parameters:
- *  In:
- *      dwIoBase       - I/O base address
- *      dwRFPowerTable - RF Tx Power Setting
- *  Out:
- *      none
- *
- * Return Value: true if succeeded; false if failed.
- *
- */
-
+/* Set Tx power by power level and rate */
 int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 {
 	u32 power_setting = 0;
@@ -846,21 +803,7 @@ int vnt_rf_set_txpower(struct vnt_private *priv, u8 power, u32 rate)
 	return ret;
 }
 
-/*+
- *
- * Routine Description:
- *     Translate RSSI to dBm
- *
- * Parameters:
- *  In:
- *      pDevice         - The adapter to be translated
- *      byCurrRSSI      - RSSI to be translated
- *  Out:
- *      pdwdbm          - Translated dbm number
- *
- * Return Value: none
- *
--*/
+/* Convert rssi to dbm */
 void vnt_rf_rssi_to_dbm(struct vnt_private *priv, u8 rssi, long *dbm)
 {
 	u8 idx = (((rssi & 0xc0) >> 6) & 0x03);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-12 10:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-12 10:30 [PATCH 1/4] staging: vt6656: rf.c clean up channel and power tables Malcolm Priestley
2014-07-12 10:30 ` [PATCH 2/4] staging: vt6656: rf.c remove dead code RFaby11aChannelIndex Malcolm Priestley
2014-07-12 10:30 ` [PATCH 3/4] staging: vt6656: vnt_rf_write_embedded add reg length and IFREGCTL_REGW Malcolm Priestley
2014-07-12 10:30 ` [PATCH 4/4] staging: vt6656: rf.c cleanup comments Malcolm Priestley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).