linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, Max Stepanov <Max.Stepanov@intel.com>
Subject: Re: [PATCH] mac80211: fix a potential NULL access in ieee80211_crypto_hw_decrypt
Date: Mon, 21 Jul 2014 12:34:16 +0200	[thread overview]
Message-ID: <1405938856.32255.22.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1404914132-13614-1-git-send-email-emmanuel.grumbach@intel.com>

On Wed, 2014-07-09 at 16:55 +0300, Emmanuel Grumbach wrote:
> From: Max Stepanov <Max.Stepanov@intel.com>
> 
> The NULL pointer access could happen when ieee80211_crypto_hw_decrypt
> is called from ieee80211_rx_h_decrypt with the following condition:
> 1. rx->key->conf.cipher is not WEP, CCMP, TKIP or AES_CMAC
> 2. rx->sta is NULL
> 
> When ieee80211_crypto_hw_decrypt is called, it verifies
> rx->sta->cipher_scheme and it will cause Oops if rx->sta is NULL.
> 
> This path adds an addirional rx->sta == NULL verification in
> ieee80211_crypto_hw_decrypt for this case.

Applied.

johannes


      reply	other threads:[~2014-07-21 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 13:55 [PATCH] mac80211: fix a potential NULL access in ieee80211_crypto_hw_decrypt Emmanuel Grumbach
2014-07-21 10:34 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405938856.32255.22.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Max.Stepanov@intel.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).