From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Philippe Duchein <wireless-dev@duchein.net>
Subject: Re: [PATCHv2 1/2] cfg80211: extend coverage_class datatype
Date: Thu, 24 Jul 2014 13:10:56 +0200 [thread overview]
Message-ID: <1406200256.14675.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1406198362-4999-2-git-send-email-lorenzo.bianconi83@gmail.com> (sfid-20140724_123925_429943_609B768D)
On Thu, 2014-07-24 at 12:39 +0200, Lorenzo Bianconi wrote:
> @@ -2242,10 +2243,15 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
> changed |= WIPHY_PARAM_COVERAGE_CLASS;
> }
>
> + if (info->attrs[NL80211_ATTR_WIPHY_DYNACK]) {
> + coverage_class = -1;
> + changed |= WIPHY_PARAM_COVERAGE_CLASS;
> + }
I think you should also reject having both dyn and fixed attributes.
You should also have a feature flag that drivers set that you test here
and refuse dynamic if it's not supported, I guess?
johannes
next prev parent reply other threads:[~2014-07-24 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 10:39 [PATCHv2 0/2] configure dynack through mac80211 stack Lorenzo Bianconi
2014-07-24 10:39 ` [PATCHv2 1/2] cfg80211: extend coverage_class datatype Lorenzo Bianconi
2014-07-24 11:09 ` Johannes Berg
2014-07-24 12:38 ` Lorenzo Bianconi
2014-07-24 11:10 ` Johannes Berg [this message]
2014-07-24 12:21 ` Lorenzo Bianconi
2014-07-24 13:01 ` Johannes Berg
2014-07-25 9:06 ` Lorenzo Bianconi
2014-07-24 10:39 ` [PATCHv2 2/2] mac80211: extend set_coverage_class signature Lorenzo Bianconi
2014-07-24 11:12 ` Johannes Berg
2014-07-24 12:12 ` Lorenzo Bianconi
2014-07-24 13:01 ` Johannes Berg
2014-07-24 15:44 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406200256.14675.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=wireless-dev@duchein.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).