From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: Arik Nemtsov <arik@wizery.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Eliad Peller <eliad@wizery.com>
Subject: Re: [PATCH] regulatory: add NULL to alpha2
Date: Tue, 29 Jul 2014 08:34:12 +0200 [thread overview]
Message-ID: <1406615652.7611.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB=NE6URWePHjBhKcWE_Jy06YbTsSWF3+xsrw9KcFYZJuv2Gsw@mail.gmail.com> (sfid-20140729_032717_589381_77A5D52B)
On Mon, 2014-07-28 at 18:26 -0700, Luis R. Rodriguez wrote:
> On Mon, Jul 21, 2014 at 3:02 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > This was never intended to be a string, only 2 characters ... so why use
> > it with string functions?
>
> Sure makes sense, the report was not clear so indeed, if userspace can
> be fixed that's better to enable consistent use.
Sadly, it looks like userspace *is* relying on a NUL-byte (e.g. iw using
nla_get_string()) which would always be there due to padding, but it's
probably better to make it explicit.
johannes
next prev parent reply other threads:[~2014-07-29 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 7:23 [PATCH] regulatory: add NULL to alpha2 Arik Nemtsov
2014-06-11 8:30 ` Luis R. Rodriguez
2014-06-11 8:39 ` Eliad Peller
2014-06-23 9:43 ` Johannes Berg
2014-06-30 22:23 ` Luis R. Rodriguez
2014-07-21 10:02 ` Johannes Berg
2014-07-29 1:26 ` Luis R. Rodriguez
2014-07-29 6:34 ` Johannes Berg [this message]
2014-07-29 11:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406615652.7611.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).