From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, Ido Yariv <ido@wizery.com>,
Ido Yariv <idox.yariv@intel.com>
Subject: Re: [PATCH] mac80211: don't resize skbs needlessly
Date: Mon, 11 Aug 2014 17:01:03 +0200 [thread overview]
Message-ID: <1407769263.9844.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1406637554-19475-1-git-send-email-emmanuel.grumbach@intel.com>
On Tue, 2014-07-29 at 15:39 +0300, Emmanuel Grumbach wrote:
> From: Ido Yariv <ido@wizery.com>
>
> Header-less cloned skbs with sufficient headroom need not be cloned
> unless the tailroom is going to be modified.
>
> Fix ieee80211_skb_resize so it would only resize cloned skbs if either
> the header isn't released or the tailroom is going to be modified.
>
> Some drivers might have assumed that skbs are never cloned, so add a HW
> flag that explicitly permits cloned TX skbs. Drivers which do not modify
> TX skbs should set this flag to avoid copying skbs.
Applied.
johannes
prev parent reply other threads:[~2014-08-11 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 12:39 [PATCH] mac80211: don't resize skbs needlessly Emmanuel Grumbach
2014-08-11 15:01 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407769263.9844.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=ido@wizery.com \
--cc=idox.yariv@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).