From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@adurom.com>
Subject: Re: [PATCH 1/2] cfg80211: clarify BSS probe response vs. beacon data
Date: Wed, 13 Aug 2014 13:08:42 +0200 [thread overview]
Message-ID: <1407928122.21220.31.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB3XZEckyoDVShskF8rRe7DFuVMO-LBdhFDejiJ63SjhsEvmAA@mail.gmail.com> (sfid-20140813_125704_716079_1D61019F)
On Wed, 2014-08-13 at 13:57 +0300, Eliad Peller wrote:
> > @@ -1011,6 +1018,9 @@ cfg80211_inform_bss_width_frame(struct wiphy *wiphy,
> > if (res->pub.capability & WLAN_CAPABILITY_ESS)
> > regulatory_hint_found_beacon(wiphy, channel, gfp);
> >
> > + /* assume drivers don't mix and match too badly */
> > + res->known_frame_type = true;
> > +
>
> i think you should set the flag only in case of a beacon.
> otherwise, you might "validate" res->ies although it contains probe
> response data.
Hm, what do you mean? If we have known frametype and we have beacon_ies,
then IEs in nl80211 are certain to be proberesp_ies ...
johannes
next prev parent reply other threads:[~2014-08-13 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 19:03 [PATCH 1/2] cfg80211: clarify BSS probe response vs. beacon data Johannes Berg
2014-08-12 19:03 ` [PATCH 2/2] cfg80211: allow passing frame type to cfg80211_inform_bss() Johannes Berg
2014-08-14 8:57 ` Kalle Valo
2014-08-14 9:23 ` Arend van Spriel
2014-08-13 10:57 ` [PATCH 1/2] cfg80211: clarify BSS probe response vs. beacon data Eliad Peller
2014-08-13 11:08 ` Johannes Berg [this message]
2014-08-13 11:13 ` Eliad Peller
2014-08-13 11:20 ` Johannes Berg
2014-08-13 11:39 ` Eliad Peller
2014-08-13 11:46 ` Johannes Berg
2014-08-13 11:57 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407928122.21220.31.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).