From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from dedo.coelho.fi ([88.198.205.34]:46674 "EHLO dedo.coelho.fi"
	rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP
	id S1751745AbaHYUJf (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
	Mon, 25 Aug 2014 16:09:35 -0400
Message-ID: <1408997366.17421.5.camel@dubbel> (sfid-20140825_220939_454544_F5D886E3)
From: Luca Coelho <luca@coelho.fi>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org, ilw@linux.intel.com,
	emmanuel.grumbach@intel.com, johannes.berg@intel.com
Date: Mon, 25 Aug 2014 23:09:26 +0300
In-Reply-To: <6715079.xd2j4mnUMo@debian64>
References: <6715079.xd2j4mnUMo@debian64>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Subject: Re: Iwlwifi 3160 AC (firmware?) clashes with
 CONFIG_IWLWIFI_BCAST_FILTERING
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

Hi Christian,

I'm not the best person to talk about the iwlwifi firmwares (that would
be Emmanuel, but he is not available now), but I'll try.

On Sat, 2014-08-23 at 00:01 +0200, Christian Lamparter wrote:
> Hello,
> 
> I got new hardware. Among the new stuff, there was one
> Intel® Dual Band Wireless-AC 3160. When I tried to connect
> to one (in fact any) of my networks, I was getting the
> following errors:
> 
> [ 1021.092378] iwlwifi 0000:01:00.0: Microcode SW error detected.  Restarting 0x82000000.
> [...]
> [ 1021.093935] iwlwifi 0000:01:00.0: Start IWL Error Log Dump:
> [ 1021.093939] iwlwifi 0000:01:00.0: Status: 0x00000000, count: 6
> [ 1021.093942] iwlwifi 0000:01:00.0: Loaded firmware version: 25.223.9.0
> [ 1021.093947] iwlwifi 0000:01:00.0: 0x00000038 | BAD_COMMAND <---                
> [ 1021.093951] iwlwifi 0000:01:00.0: 0x00A00220 | uPc

Where did you get this firmware version? AFAICT the last version
Emmanuel sent to linux-firmware.git is 23.214.9.0 (the one you also
mentioned below).


> [...]
> [ 1021.094192] Call Trace:
> [ 1021.094205]  [<ffffffff813ce9bd>] ? dump_stack+0x41/0x51
> [ 1021.094217]  [<ffffffffa0b9cd8b>] ? iwl_trans_pcie_send_hcmd+0x367/0x438 [iwlwifi]
> [ 1021.094226]  [<ffffffffa0b9b52c>] ? iwl_pcie_enqueue_hcmd+0x5e3/0x5fe [iwlwifi]
> [ 1021.094235]  [<ffffffff8105fd4c>] ? finish_wait+0x5d/0x5d
> [ 1021.094250]  [<ffffffffa0d50106>] ? iwl_mvm_send_cmd+0xd/0x22 [iwlmvm]
> [ 1021.094262]  [<ffffffffa0d50160>] ? iwl_mvm_send_cmd_pdu+0x45/0x52 [iwlmvm]
> [ 1021.094273]  [<ffffffffa0d4c5fb>] ? iwl_mvm_configure_bcast_filter.isra.14.part.15+0x36/0x3f [iwlmvm]
> 
> (Full log attached below)
> 
> What cough my eye was the "BAD_COMMAND" in the error log. I disabled
> "CONFIG_IWLWIFI_BCAST_FILTERING" option and the 3160 is now working.
> 
> As far as I can tell, there is already a firmware feature flag:
> "IWL_UCODE_TLV_FLAGS_BCAST_FILTERING" which can be used to
> distinguish whenever the feature is supported or not. But it
> seems to be "stuck on" for the 3160.

Weird, but it's possible that they set the flag mistakenly for the 3160
firmware.  I'll check this with the firmware team.


> Regards
> Christian
> 
> BTW: I also tried the older "23.214.9.0" firmware too.
> => Same result [Doesn't work with BCAST_FILTERING enabled].

Thanks a lot for your report! Broadcast filtering is not set by default,
so I haven't seen that bug before.

--
Cheers,
Luca.