From: Johannes Berg <johannes@sipsolutions.net>
To: Henning Rogge <hrogge@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Subject: Re: [Patch]mac80211: Add support for mesh proxy path dump
Date: Wed, 03 Sep 2014 13:52:13 +0200 [thread overview]
Message-ID: <1409745133.911.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <2937689.hWkxdbjQ3v@rogge-hp-probook-6470b> (sfid-20140901_132615_830692_B0FE7837)
On Mon, 2014-09-01 at 13:26 +0200, Henning Rogge wrote:
> The following patch adds NL80211_CMD_GET_MPP as a new nl80211 command that
> allows to query the content of the 'mesh proxy path' table of mac80211s via
> 'get' or 'dump' operation.
For review and merging, and to make it more obvious to you as well when
writing commit logs/documentation/etc I'd prefer if you'd split this up
into separate cfg80211 and mac80211 patches.
> + int (*get_mpp)(struct wiphy *wiphy, struct net_device *dev,
> + u8 *dst, u8 *mpp, struct mpath_info *pinfo);
> + int (*dump_mpp)(struct wiphy *wiphy, struct net_device *dev,
> + int idx, u8 *dst, u8 *mpp,
> + struct mpath_info *pinfo);
Should dst/mpp be const? Or are those output parameters?
Should it really be mpath_info? I thought this was some other thing?
Probably just need more documentation :)
johannes
next prev parent reply other threads:[~2014-09-03 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 11:26 [Patch]mac80211: Add support for mesh proxy path dump Henning Rogge
2014-09-01 12:03 ` Henning Rogge
2014-09-02 6:29 ` Yeoh Chun-Yeow
2014-09-02 8:03 ` Johannes Berg
2014-09-02 8:15 ` Henning Rogge
2014-09-03 11:52 ` Johannes Berg [this message]
2014-09-03 12:12 ` Henning Rogge
2014-09-03 12:25 ` Johannes Berg
2014-09-03 12:32 ` Henning Rogge
2014-09-03 12:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409745133.911.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hrogge@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).