From: Johannes Berg <johannes@sipsolutions.net>
To: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 1/2] mac80211: split 802.11h parsing from transmit power policy
Date: Wed, 03 Sep 2014 13:56:40 +0200 [thread overview]
Message-ID: <1409745400.911.10.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <E1XONJ6-0005Kl-Nz@pannekake.samfundet.no> (sfid-20140901_104956_330419_87FE5F12)
On Fri, 2014-08-29 at 19:27 +0200, Steinar H. Gunderson wrote:
> ieee80211_find_80211h_pwr_constr
Please format the code like this:
static bool
ieee80211_find_80211h_pwr_constr(struct ieee80211_sub_if_data *sdata,
struct ieee80211_channel *channel,
const u8 *country_ie, u8
country_ie_len,
const u8 *pwr_constr_elem,
int *chan_pwr, int *pwr_reduction)
Do we need the pwr_reduction? Couldn't we just return it? We don't
handle 0/negative anyway, do we?
> -static u32 ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata,
> +static bool ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata,
I think you meant to keep u32 here? Otherwise return values from the
function simply get converted to 0/1 which doesn't seem right.
johannes
next prev parent reply other threads:[~2014-09-03 11:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 21:28 [PATCH] Support Cisco DTPC IE to reduce transmit power Steinar H. Gunderson
2014-08-24 10:37 ` Steinar H. Gunderson
2014-08-24 10:08 ` [PATCH] Support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-08-28 7:43 ` Johannes Berg
2014-08-28 8:37 ` Steinar H. Gunderson
2014-08-29 8:19 ` Steinar H. Gunderson
2014-08-29 17:27 ` [PATCH 1/2] mac80211: split 802.11h parsing from transmit power policy Steinar H. Gunderson
2014-08-29 17:38 ` [PATCH 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-08-30 0:24 ` [PATCH] Support " Steinar H. Gunderson
2014-08-30 18:45 ` Steinar H. Gunderson
2014-08-29 17:27 ` [PATCH v5 1/2] mac80211: split 802.11h parsing from transmit power policy Steinar H. Gunderson
2014-09-03 11:56 ` Johannes Berg [this message]
2014-09-03 13:21 ` Steinar H. Gunderson
2014-08-29 17:27 ` [PATCH " Steinar H. Gunderson
2014-08-29 17:38 ` [PATCH 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-08-29 17:38 ` [PATCH v5 " Steinar H. Gunderson
2014-09-03 12:00 ` Johannes Berg
2014-09-03 13:33 ` Steinar H. Gunderson
2014-09-03 13:22 ` [PATCH v6 1/2] mac80211: split 802.11h parsing from transmit power policy Steinar H. Gunderson
2014-09-03 13:48 ` [PATCH v6 2/2] mac80211: support DTPC IE (from Cisco Client eXtensions) Steinar H. Gunderson
2014-09-08 8:53 ` Johannes Berg
2014-09-16 23:47 ` Steinar H. Gunderson
2014-10-06 14:52 ` Johannes Berg
2014-10-06 14:54 ` Steinar H. Gunderson
2014-09-03 19:12 ` [PATCH v5 " Johannes Berg
2014-09-07 17:02 ` Steinar H. Gunderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409745400.911.10.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgunderson@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).