From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: g@tuxdriver.com, Jouni Malinen <j@w1.fi>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] hostap: proc: substitute loops by %*phN
Date: Fri, 12 Sep 2014 10:24:10 +0300 [thread overview]
Message-ID: <1410506650.7023.29.camel@linux.intel.com> (raw)
In-Reply-To: <20140911192721.GD22872@tuxdriver.com>
On Thu, 2014-09-11 at 15:27 -0400, John W. Linville wrote:
> Applying: hostap: proc: substitute loops by %*phN
> error: patch failed: drivers/net/wireless/hostap/hostap_proc.c:184
> error: drivers/net/wireless/hostap/hostap_proc.c: patch does not apply
Hmm... Originally it was applied on top of linux-next (few days ago).
Just checking with current origin/master. Applied correctly.
Moreover, took recent wireless-next. No issues.
Which tree you are trying?
>
> On Fri, Sep 05, 2014 at 05:30:16PM +0300, Andy Shevchenko wrote:
> > For dumping small buffers we may use %*phN specifier instead of custom
> > approach..
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/net/wireless/hostap/hostap_proc.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> > index 16a06b6..4e2a7dd9 100644
> > --- a/drivers/net/wireless/hostap/hostap_proc.c
> > +++ b/drivers/net/wireless/hostap/hostap_proc.c
> > @@ -184,11 +184,9 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
> > seq_printf(m, "%*pE", bss->ssid_len, bss->ssid);
> >
> > seq_putc(m, '\t');
> > - for (i = 0; i < bss->ssid_len; i++)
> > - seq_printf(m, "%02x", bss->ssid[i]);
> > + seq_printf(m, "%*phN", (int)bss->ssid_len, bss->ssid);
> > seq_putc(m, '\t');
> > - for (i = 0; i < bss->wpa_ie_len; i++)
> > - seq_printf(m, "%02x", bss->wpa_ie[i]);
> > + seq_printf(m, "%*phN", (int)bss->wpa_ie_len, bss->wpa_ie);
> > seq_putc(m, '\n');
> > return 0;
> > }
> > --
> > 2.1.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2014-09-12 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 14:30 [PATCH] hostap: proc: substitute loops by %*phN Andy Shevchenko
2014-09-11 19:27 ` John W. Linville
2014-09-12 7:24 ` Andy Shevchenko [this message]
2014-09-15 19:02 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410506650.7023.29.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=g@tuxdriver.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).