From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/4] wireless: expose set-wiphy-name method to other modules.
Date: Mon, 06 Oct 2014 16:27:14 +0200 [thread overview]
Message-ID: <1412605634.3098.18.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1411773856-25042-1-git-send-email-greearb@candelatech.com> (sfid-20140927_012441_483840_20B8643D)
On Fri, 2014-09-26 at 16:24 -0700, greearb@candelatech.com wrote:
> +/*
> + * Attempt to rename a device. Acquire RTNL before calling.
> + */
please add kernel-doc
> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname);
Should also be const char *
And should probably be called cfg80211_rename_wiphy() only? What's the
dev doing there?
>
> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname)
> +{
> + struct cfg80211_registered_device *rdev;
> +
> + rdev = wiphy_to_rdev(wiphy);
> + return cfg80211_dev_rename(rdev, newname);
You could just inlin ethe wiphy_to_rdev() and get rid of the variable.
Anyhow - if the intent is to do this at creation, why do you do it after
the fact? Couldn't you just specify the name when creating it?
johannes
next prev parent reply other threads:[~2014-10-06 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 23:24 [PATCH v2 1/4] wireless: expose set-wiphy-name method to other modules greearb
2014-09-26 23:24 ` [PATCH v2 2/4] mac-sim: support creating radios with specific name greearb
2014-09-26 23:24 ` [PATCH v2 3/4] wireless: support creating wiphy w/out creating wlanX greearb
2014-09-26 23:24 ` [PATCH v2 4/4] hwsim: " greearb
2014-10-06 14:28 ` Johannes Berg
2014-10-06 14:27 ` Johannes Berg [this message]
2014-10-06 18:26 ` [PATCH v2 1/4] wireless: expose set-wiphy-name method to other modules Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412605634.3098.18.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).