linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Arend van Spriel <arend@broadcom.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] cfg80211: allow to configure dynamic PS timeout
Date: Mon, 06 Oct 2014 17:00:40 +0200	[thread overview]
Message-ID: <1412607640.3098.33.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20141001092710.GB2011@redhat.com>

On Wed, 2014-10-01 at 11:27 +0200, Stanislaw Gruszka wrote:
> Dynamic power save timeout value is suppose to be configurable via
> wext, but due to iwconfig bug is not possible to set using that tool.

That's interesting, what's that bug?

> Allow to configure PS timeout via nl80211 - add NL80211_ATTR_PS_TIMEOUT
> attribute which become timeout stated in ms.

Why do you want to be able to set it at all though? I remember having
this discussion years ago, and we said that it wasn't really useful
since the user has no idea when and why this should be changed. I'm not
convinced that changed?

We had to keep the wext for compatibility - maybe that can now be
removed if you say it's broken - but I'm not sure I see much value in
adding it (and you're doing nothing to convince me otherwise, so far)

johannes


  reply	other threads:[~2014-10-06 15:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 13:18 [PATCH] cfg80211: allow to configure dynamic PS timeout Stanislaw Gruszka
2014-09-30 14:04 ` Arend van Spriel
2014-09-30 14:05   ` Arend van Spriel
2014-10-01  9:27     ` [PATCH v2] " Stanislaw Gruszka
2014-10-06 15:00       ` Johannes Berg [this message]
2014-10-07 11:03         ` Stanislaw Gruszka
2014-10-07 12:05           ` Johannes Berg
2014-10-07 12:32             ` Krishna Chaitanya
2014-10-07 12:47               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412607640.3098.33.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).