From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 6/6] cfg80211: support configuring vdev mac addr on create.
Date: Tue, 21 Oct 2014 21:42:36 +0200 [thread overview]
Message-ID: <1413920556.1998.26.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1413845378-27837-6-git-send-email-greearb@candelatech.com>
Same comment regarding "vdev", here starting from the subject.
Also, this patch isn't purely cfg80211 - should probably split it into
cfg80211 and mac80211 parts?
On Mon, 2014-10-20 at 15:49 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This is useful when creating virtual-stations, and probably
> APs and other devices as well.
It clearly is - imho worth rephrasing as just "when creating virtual
interfaces" :-)
> +++ b/include/net/cfg80211.h
> @@ -319,9 +319,9 @@ struct ieee80211_supported_band {
> /**
> * struct vif_params - describes virtual interface parameters
> * @use_4addr: use 4-address frames
> - * @macaddr: address to use for this virtual interface. This will only
> - * be used for non-netdevice interfaces. If this parameter is set
> - * to zero address the driver may determine the address as needed.
> + * @macaddr: address to use for this virtual interface.
> + * If this parameter is set to zero address the driver may
> + * determine the address as needed.
Maybe point to the feature flag here.
> + * @NL80211_FEATURE_MAC_ON_CREATE: Device supports configuring
> + * the vdev's MAC address upon creation.
Maybe point to the attribute that's used for that here?
johannes
next prev parent reply other threads:[~2014-10-21 19:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 22:49 [PATCH v2 1/6] cfg80211: support creating wiphy with suggested name greearb
2014-10-20 22:49 ` [PATCH v2 2/6] mac80211: allow creating wiphy devices " greearb
2014-10-21 19:34 ` Johannes Berg
2014-10-20 22:49 ` [PATCH v2 3/6] mac80211-hwsim: support creating radios with specific name greearb
2014-10-21 19:35 ` Johannes Berg
2014-10-20 22:49 ` [PATCH v2 4/6] cfg80211: support creating wiphy w/out creating wlanX greearb
2014-10-21 19:38 ` Johannes Berg
2014-10-20 22:49 ` [PATCH v2 5/6] mac80211-hwsim: " greearb
2014-10-21 19:39 ` Johannes Berg
2014-10-20 22:49 ` [PATCH v2 6/6] cfg80211: support configuring vdev mac addr on create greearb
2014-10-21 19:42 ` Johannes Berg [this message]
2014-10-21 19:31 ` [PATCH v2 1/6] cfg80211: support creating wiphy with suggested name Johannes Berg
2014-10-21 20:10 ` Ben Greear
2014-10-22 16:07 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413920556.1998.26.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).