From: Johannes Berg <johannes@sipsolutions.net>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: Karl Beldan <karl.beldan@rivierawaves.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH v5 0/4] add VHT support to minstrel_ht
Date: Wed, 22 Oct 2014 16:16:34 +0200 [thread overview]
Message-ID: <1413987394.28927.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20141022141547.GB29537@magnum.frso.rivierawaves.com> (sfid-20141022_161551_566780_F7C38129)
On Wed, 2014-10-22 at 16:15 +0200, Karl Beldan wrote:
> > Wait, are you saying it *is* out of bounds when VHT isn't turned on?
> >
>
> The smatch warning pops on
> {
> if (!(mi->groups[i].supported & BIT(j)))
> continue;
> ...
> else if (i >= MINSTREL_VHT_GROUP_0)
> }
>
> MINSTREL_VHT_GROUP_0 is out of bonds (not i which remains <
> ARRAY_SIZE(mi->groups)).
Ah, ok, right.
johannes
prev parent reply other threads:[~2014-10-22 14:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 13:45 [PATCH v5 0/4] add VHT support to minstrel_ht Karl Beldan
2014-10-20 13:45 ` [PATCH v5 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes Karl Beldan
2014-10-20 13:46 ` [PATCH v5 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs Karl Beldan
2014-10-20 13:46 ` [PATCH v5 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag Karl Beldan
2014-10-20 13:46 ` [PATCH v5 4/4] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Karl Beldan
2014-10-21 8:38 ` [PATCH v6] " Karl Beldan
2014-10-24 11:48 ` Karl Beldan
2014-10-24 12:01 ` Johannes Berg
2014-10-24 12:34 ` [PATCH] mac80211: minstrel_ht: do not always skip ht rates vht_only is true Karl Beldan
2014-10-24 12:40 ` Karl Beldan
2014-10-24 14:30 ` Johannes Berg
2014-10-24 14:33 ` Karl Beldan
2014-11-14 16:43 ` [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates <= 3SS@80MHz Jouni Malinen
2014-11-14 17:18 ` Karl Beldan
2014-11-14 17:36 ` Jouni Malinen
2014-11-14 18:29 ` Karl Beldan
2014-11-14 22:40 ` Karl Beldan
2014-10-20 14:49 ` [PATCH v5 0/4] add VHT support to minstrel_ht Johannes Berg
2014-10-20 15:13 ` Karl Beldan
2014-10-20 15:34 ` Karl Beldan
2014-10-20 19:33 ` Johannes Berg
2014-10-20 19:40 ` Johannes Berg
2014-10-21 8:41 ` Karl Beldan
2014-10-21 15:26 ` Karl Beldan
2014-10-21 18:47 ` Johannes Berg
2014-10-22 13:54 ` Karl Beldan
2014-10-22 14:07 ` Johannes Berg
2014-10-22 14:15 ` Karl Beldan
2014-10-22 14:16 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413987394.28927.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).