From: Johannes Berg <johannes@sipsolutions.net>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO
Date: Wed, 29 Oct 2014 16:50:07 +0100 [thread overview]
Message-ID: <1414597807.1827.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1414406688-3827-3-git-send-email-jukka.rissanen@linux.intel.com> (sfid-20141027_114540_063766_7C3E5B4A)
On Mon, 2014-10-27 at 12:44 +0200, Jukka Rissanen wrote:
> +static void mcast_msg(struct sk_buff *mcast_skb, struct genl_info *info)
> +{
> + if (info)
> + genl_notify(&hwsim_genl_family, mcast_skb,
> + genl_info_net(info), info->snd_portid,
> + HWSIM_MCGRP_CONFIG, info->nlhdr, GFP_KERNEL);
> + else
> + genlmsg_multicast(&hwsim_genl_family, mcast_skb, 0,
> + HWSIM_MCGRP_CONFIG, GFP_KERNEL);
> +}
Also - given the parameters and what this does, that's a bad name for
the function. Never mind that it doesn't have any sort of identifier
(say hwsim_ prefix), it doesn't even do what it says it does.
johannes
next prev parent reply other threads:[~2014-10-29 15:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 10:44 [PATCH 0/3] Add mcast event when hwsim radios are created and removed Jukka Rissanen
2014-10-27 10:44 ` [PATCH 1/3] mac80211-hwsim: Rename CREATE and DESTROY radio to NEW and DEL radio Jukka Rissanen
2014-10-29 15:48 ` Johannes Berg
2014-10-27 10:44 ` [PATCH 2/3] mac80211-hwsim: Provide multicast event for HWSIM_CMD_NEW_RADIO Jukka Rissanen
2014-10-29 15:48 ` Johannes Berg
2014-10-29 15:50 ` Johannes Berg [this message]
2014-10-29 15:53 ` Johannes Berg
2014-10-30 14:28 ` Jukka Rissanen
2014-10-27 10:44 ` [PATCH 3/3] mac80211-hwsim: Provide multicast event for HWSIM_CMD_DEL_RADIO Jukka Rissanen
2014-10-27 11:20 ` [PATCH 0/3] Add mcast event when hwsim radios are created and removed Johannes Berg
2014-10-27 11:29 ` Jukka Rissanen
2014-10-27 11:31 ` Johannes Berg
2014-10-27 11:55 ` Jukka Rissanen
2014-10-27 12:08 ` Johannes Berg
2014-10-27 14:19 ` Marcel Holtmann
2014-10-27 17:34 ` Luca Coelho
2014-10-27 23:14 ` Marcel Holtmann
2014-10-27 23:22 ` Ben Greear
2014-10-28 6:42 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414597807.1827.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).