From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0175.hostedemail.com ([216.40.44.175]:59674 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933873AbaJ2QIp (ORCPT ); Wed, 29 Oct 2014 12:08:45 -0400 Message-ID: <1414598919.11707.3.camel@perches.com> (sfid-20141029_170850_056546_74083623) Subject: Re: [patch] ath9k: fix some debugfs output From: Joe Perches To: Dan Carpenter Cc: QCA ath9k Development , "John W. Linville" , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net, kernel-janitors@vger.kernel.org Date: Wed, 29 Oct 2014 09:08:39 -0700 In-Reply-To: <20141029154805.GC5290@mwanda> References: <20141029154805.GC5290@mwanda> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: > The right shift operation has higher precedence than the mask so we > left shift by "(i * 3)" and then immediately right shift by "(i * 3)" > then we mask. It should be left shift, mask, and then right shift. > Hey Dan. My grep pattern doesn't like operations on the thing masked. Did you find this by some tool or visual inspection via grep?