From: Johannes Berg <johannes@sipsolutions.net>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211-hwsim: add frequency attribute to netlink pkts
Date: Fri, 31 Oct 2014 09:04:46 +0100 [thread overview]
Message-ID: <1414742686.3014.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1414742568.2918.11.camel@jrissane-mobl.ger.corp.intel.com>
On Fri, 2014-10-31 at 10:02 +0200, Jukka Rissanen wrote:
> while rebasing my hwsim patches on top of Ben's patches, I noticed that
> the freq attribute is not mentioned in hwsim_genl_policy struct. The
> same applies also to radio name and vif attributes. Just wondered should
> they be mentioned in the policy struct like the other attributes?
Hmm, yes, they should be there. It's only important for the name, I
guess, but better have them all. I can fix it or would you like to send
a patch?
johannes
next prev parent reply other threads:[~2014-10-31 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 22:04 [PATCH] mac80211-hwsim: add frequency attribute to netlink pkts greearb
2014-10-29 15:55 ` Johannes Berg
2014-10-29 16:02 ` Ben Greear
2014-10-29 16:11 ` Johannes Berg
2014-10-31 8:02 ` Jukka Rissanen
2014-10-31 8:04 ` Johannes Berg [this message]
2014-10-31 8:16 ` Jukka Rissanen
2014-10-31 8:26 ` Johannes Berg
2014-10-31 15:50 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414742686.3014.15.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).