From: Johannes Berg <johannes@sipsolutions.net>
To: Rostislav Lisovy <lisovy@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Sojka <sojkam1@fel.cvut.cz>,
s.sander@nordsys.de, jan-niklas.meier@volkswagen.de,
burak.simsek@volkswagen.de,
Emmanuel Thierry <emmanuel.thierry@yogoko.fr>,
laszlo.virag@commsignia.com,
Rostislav Lisovy <rostislav.lisovy@fel.cvut.cz>
Subject: Re: [PATCH 2/2] mac80211: 802.11p OCB mode support
Date: Fri, 31 Oct 2014 14:29:18 +0100 [thread overview]
Message-ID: <1414762158.3014.33.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1414665771-8371-3-git-send-email-rostislav.lisovy@fel.cvut.cz> (sfid-20141030_114323_275977_11FDCB49)
On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote:
> +int ieee80211_ocb_join(struct ieee80211_sub_if_data *sdata,
> + struct ocb_setup *setup)
> +{
> + struct ieee80211_local *local = sdata->local;
> + struct ieee80211_if_ocb *ifocb = &sdata->u.ocb;
> + u32 changed = BSS_CHANGED_OCB;
> + int err;
> +
> + if (ifocb->joined == true)
> + return -EINVAL;
You could, potentially, use the fact that you have a channel context
assigned instead. However, locking might make that awkward, and this is
perfectly fine as well of course. It's probably not worth changing it.
Looks good to me.
johannes
next prev parent reply other threads:[~2014-10-31 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 10:42 [PATCH 0/2 v2] cfg80211: mac80211: 802.11p OCB mode support Rostislav Lisovy
2014-10-30 10:42 ` [PATCH 1/2] cfg80211: 802.11p OCB mode handling Rostislav Lisovy
2014-10-31 13:13 ` Johannes Berg
2014-10-31 15:12 ` Rostislav Lisovy
2014-10-31 15:15 ` Johannes Berg
2014-10-30 10:42 ` [PATCH 2/2] mac80211: 802.11p OCB mode support Rostislav Lisovy
2014-10-31 13:29 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-03 9:33 [PATCH 0/2 v3] cfg80211: " Rostislav Lisovy
2014-11-03 9:33 ` [PATCH 2/2] " Rostislav Lisovy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414762158.3014.33.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=burak.simsek@volkswagen.de \
--cc=emmanuel.thierry@yogoko.fr \
--cc=jan-niklas.meier@volkswagen.de \
--cc=laszlo.virag@commsignia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lisovy@gmail.com \
--cc=rostislav.lisovy@fel.cvut.cz \
--cc=s.sander@nordsys.de \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox