* [PATCH v2] mac80211: Increase uapsd max SP frames number
@ 2014-11-04 9:33 Emmanuel Grumbach
2014-11-04 10:17 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Emmanuel Grumbach @ 2014-11-04 9:33 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Andrei Otcheretianski, Emmanuel Grumbach
From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Deliver up to 128 frames during SP instead of 8 if unlimited
max SP is specified during association.
8 was just an arbitrary value, so is 128 since unlimited can
be any number.
However for large traffic bursts, increasing this value looks
reasonable. Also, it seems that a few certification tests
expect more frames to be delivered during SP.
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
v2: change commit message
---
net/mac80211/sta_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index de494df..3352741 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -1531,7 +1531,7 @@ void ieee80211_sta_ps_deliver_uapsd(struct sta_info *sta)
break;
case 0:
/* XXX: what is a good value? */
- n_frames = 8;
+ n_frames = 128;
break;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mac80211: Increase uapsd max SP frames number
2014-11-04 9:33 [PATCH v2] mac80211: Increase uapsd max SP frames number Emmanuel Grumbach
@ 2014-11-04 10:17 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2014-11-04 10:17 UTC (permalink / raw)
To: Emmanuel Grumbach; +Cc: linux-wireless, Andrei Otcheretianski
On Tue, 2014-11-04 at 11:33 +0200, Emmanuel Grumbach wrote:
> From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
>
> Deliver up to 128 frames during SP instead of 8 if unlimited
> max SP is specified during association.
> 8 was just an arbitrary value, so is 128 since unlimited can
> be any number.
> However for large traffic bursts, increasing this value looks
> reasonable. Also, it seems that a few certification tests
> expect more frames to be delivered during SP.
Applied.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-04 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04 9:33 [PATCH v2] mac80211: Increase uapsd max SP frames number Emmanuel Grumbach
2014-11-04 10:17 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).