From: Johannes Berg <johannes@sipsolutions.net>
To: Henning Rogge <hrogge@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Henning Rogge <henning.rogge@fkie.fraunhofer.de>
Subject: Re: [PATCH] cfg80211: fix nl80211 cmd id in nl80211_send_mpath()
Date: Tue, 04 Nov 2014 17:05:10 +0100 [thread overview]
Message-ID: <1415117110.2064.21.camel@sipsolutions.net> (raw)
In-Reply-To: <CAGnRvuo4TzrwSfQF5SUKUKptvFxEeqVTx9zg3KfGnEU=aokyQA@mail.gmail.com> (sfid-20141104_165716_359630_3B8E329C)
On Tue, 2014-11-04 at 16:56 +0100, Henning Rogge wrote:
> Hi,
>
> the only reason why nobody noticed is that the "iw" tool does not even
> check the cmd field of the kernel replies it process. I wonder if "iw"
> should check the value, just to make sure bugs like this are easier to
> detect.
It doesn't really have to since it's not processing events on the same
socket ... but maybe we should just add some sanity checks.
johannes
prev parent reply other threads:[~2014-11-04 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 15:14 [PATCH] cfg80211: fix nl80211 cmd id in nl80211_send_mpath() Henning Rogge
2014-11-04 15:37 ` Johannes Berg
2014-11-04 15:56 ` Henning Rogge
2014-11-04 16:05 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415117110.2064.21.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=henning.rogge@fkie.fraunhofer.de \
--cc=hrogge@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).