From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add back support for radiotap vendor namespace data
Date: Fri, 07 Nov 2014 20:15:21 +0100 [thread overview]
Message-ID: <1415387721.1954.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1415363870.12617.0.camel@coelho.fi>
On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote:
> > +#if 0
> > + struct ieee80211_vendor_radiotap *rtap;
> > +
> > + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4);
> > + /*
> > + * Don't enable this code by default as the OUI 00:00:00
> > + * is registered to Xerox so we shouldn't use it here, it
> > + * might find its way into pcap files.
> > + * Note that this code requires the headroom in the SKB
> > + * that was allocated earlier.
> > + */
> Is this #if 0'ed section here on purpose? If yes, maybe explain it in
> the commit message?
You're the second person to ask this, but come on ... really? :)
johannes
next prev parent reply other threads:[~2014-11-07 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 22:29 [PATCH] mac80211: add back support for radiotap vendor namespace data Johannes Berg
2014-11-06 22:31 ` Ben Greear
2014-11-06 22:32 ` Johannes Berg
2014-11-07 12:37 ` Luca Coelho
2014-11-07 19:15 ` Johannes Berg [this message]
2014-11-07 19:37 ` Luca Coelho
2014-11-08 13:33 ` Arend van Spriel
2014-11-10 6:49 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415387721.1954.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).