linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Patrik Flykt <patrik.flykt@linux.intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211-hwsim: Add HWSIM_CMD_GET_RADIO command
Date: Mon, 10 Nov 2014 10:34:57 +0100	[thread overview]
Message-ID: <1415612097.1847.8.camel@sipsolutions.net> (raw)
In-Reply-To: <1415348520-28558-3-git-send-email-patrik.flykt@linux.intel.com> (sfid-20141107_092210_311728_E4CAFF7C)

On Fri, 2014-11-07 at 10:22 +0200, Patrik Flykt wrote:

> +static int hwsim_dump_radio_nl(struct sk_buff *skb,
> +			       struct netlink_callback *cb)
> +{
> +	struct mac80211_hwsim_data *data = NULL;
> +
> +	spin_lock_bh(&hwsim_radio_lock);
> +
> +	list_for_each_entry(data, &hwsim_radios, list)
> +		mac80211_hwsim_get_radio(skb, data,
> +					 NETLINK_CB(cb->skb).portid,
> +					 cb->nlh->nlmsg_seq, cb, NLM_F_MULTI);
> +
> +	spin_unlock_bh(&hwsim_radio_lock);

Err, I don't think this is how dump works?

Try dumping a few hundred radios this way.

johannes


      reply	other threads:[~2014-11-10  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  8:21 [PATCH 0/2] Add HWSIM_CMD_GET_RADIO command Patrik Flykt
2014-11-07  8:21 ` [PATCH 1/2] mac80211-hwsim: Factor out netlink attribute appending Patrik Flykt
2014-11-10  9:32   ` Johannes Berg
2014-11-12 13:08     ` Patrik Flykt
2014-11-07  8:22 ` [PATCH 2/2] mac80211-hwsim: Add HWSIM_CMD_GET_RADIO command Patrik Flykt
2014-11-10  9:34   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415612097.1847.8.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=patrik.flykt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).