From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:57224 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbaKKJ3k (ORCPT ); Tue, 11 Nov 2014 04:29:40 -0500 Message-ID: <1415698161.2163.0.camel@sipsolutions.net> (sfid-20141111_103013_707715_A61D4522) Subject: Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver From: Johannes Berg To: "Gautam (Gautam Kumar) Shukla" Cc: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "davem@davemloft.net" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Jithu Jance , Sreenath S Date: Tue, 11 Nov 2014 10:29:21 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2014-11-11 at 05:56 +0000, Gautam (Gautam Kumar) Shukla wrote: > For offloading 4 way handshake to driver, currently we don't have any > member of struct cfg80211_connect_params to pass PSK from supplicant > to driver. I have added psk for the same and added rest of the code > needed in nl80211.h and nl80211.c to parse and make it available to > driver. > From supplicant, we already have psk member field in assoc_params to > use . > > Tested on x86 linux. Your commit message needs serious work. Also, there's a competing approach from QCA that's far more suited. In either case though, I'm going to ask which driver is going to use this and when it's going to land in mainline. johannes