From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>
Subject: Re: Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ?
Date: Thu, 13 Nov 2014 13:44:43 +0100 [thread overview]
Message-ID: <1415882683.2021.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20141113123313.GA1926@redhat.com> (sfid-20141113_133628_786084_BDEA3269)
On Thu, 2014-11-13 at 13:33 +0100, Stanislaw Gruszka wrote:
> I've updated wireless code on RHEL and get complain that now
> cfg80211 and rfkill modules are loaded on machines that do not have
> wireless hardware. Modules are auto-loaded because NetworkManager send
> nl80211 messages to check if there are wireless devices in the system.
>
> Hence my question, can we revert commit fb4e156886ce
> "nl80211: Add generic netlink module alias for cfg80211/nl80211" ?
Realistically, we can't revert it, but only remove the
MODULE_ALIAS_GENL_FAMILY() line.
> Auto loading nl80211 does not seems to be necessary, if there are
> wireless devices nl80211 will be loaded anyway.
Maybe other applications would like to see an empty list of devices? But
OTOH, if they're robust at all, they have to cope with kernels not even
compiled with nl80211, so I guess for me I don't really see a big
difference in whether the module alias exists or not.
johannes
next prev parent reply other threads:[~2014-11-13 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 12:33 Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ? Stanislaw Gruszka
2014-11-13 12:44 ` Johannes Berg [this message]
2014-11-13 13:22 ` [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias Stanislaw Gruszka
2014-11-13 13:36 ` Marcel Holtmann
2014-11-13 13:39 ` Stanislaw Gruszka
2014-11-13 13:48 ` Marcel Holtmann
2014-11-14 2:56 ` Dan Williams
2014-11-14 7:08 ` Marcel Holtmann
2014-11-14 8:39 ` Stanislaw Gruszka
2014-11-13 13:41 ` Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ? Marcel Holtmann
2014-11-14 2:55 ` Dan Williams
2014-11-14 6:09 ` Luca Coelho
2014-11-14 6:57 ` Marcel Holtmann
2014-11-14 8:41 ` Stanislaw Gruszka
2014-11-14 7:02 ` Marcel Holtmann
2014-11-14 8:42 ` Stanislaw Gruszka
2014-11-14 16:02 ` Dan Williams
2014-11-14 17:10 ` Dan Williams
2014-11-19 17:13 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415882683.2021.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).