linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias
Date: Thu, 13 Nov 2014 20:56:57 -0600	[thread overview]
Message-ID: <1415933817.2629.14.camel@dcbw.local> (raw)
In-Reply-To: <4E8F3B23-EC77-4B53-8180-7DB12042E0B5@holtmann.org>

On Thu, 2014-11-13 at 22:48 +0900, Marcel Holtmann wrote:
> Hi Stanislaw,
> 
> >>> With the alias cfg80211 module is loaded on systems without the wireless
> >>> hardware when user-space use nl80211 to discover if there are wireless
> >>> devices, what is considered as resources wastage. On systems with
> >>> wireless hardware cfg80211 module will be loaded anyway.
> >>> 
> >>> Cc: Marcel Holtmann <marcel@holtmann.org>
> >>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> >>> ---
> >>> net/wireless/core.c | 1 -
> >>> 1 file changed, 1 deletion(-)
> >>> 
> >>> diff --git a/net/wireless/core.c b/net/wireless/core.c
> >>> index a4d2792..badcabe 100644
> >>> --- a/net/wireless/core.c
> >>> +++ b/net/wireless/core.c
> >>> @@ -34,7 +34,6 @@
> >>> MODULE_AUTHOR("Johannes Berg");
> >>> MODULE_LICENSE("GPL");
> >>> MODULE_DESCRIPTION("wireless configuration support");
> >>> -MODULE_ALIAS_GENL_FAMILY(NL80211_GENL_NAME);
> >> 
> >> NAK.
> >> 
> >> We want to auto-load cfg80211 when userspace asked for nl80211 netlink family.
> > 
> > Could you elaborate more why?
> 
> you want to talk to the nl80211 family. The kernel has a module that allows you to talk to this family. So let it load the netlink family.
> 
> If you do not want cfg80211 loaded, then fix NetworkManager and not hack the kernel. NetworkManager asks to talk to nl80211 in the first place. That one is causing the loading of cfg80211 module.

Unfortunately there seems to be no reliable way of detecting that an
ethernet-type interface is WiFi (and talks nl80211) or is not WiFi, than
by asking it, using nl80211.  Unless you have suggestions for this?

Dan


  reply	other threads:[~2014-11-14  2:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 12:33 Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ? Stanislaw Gruszka
2014-11-13 12:44 ` Johannes Berg
2014-11-13 13:22   ` [PATCH] cfg80211: remove net-pf-16-proto-16-family-nl80211 module alias Stanislaw Gruszka
2014-11-13 13:36     ` Marcel Holtmann
2014-11-13 13:39       ` Stanislaw Gruszka
2014-11-13 13:48         ` Marcel Holtmann
2014-11-14  2:56           ` Dan Williams [this message]
2014-11-14  7:08             ` Marcel Holtmann
2014-11-14  8:39           ` Stanislaw Gruszka
2014-11-13 13:41   ` Can fb4e156886ce6e8309e912d8b370d192330d19d3 be reverted ? Marcel Holtmann
2014-11-14  2:55     ` Dan Williams
2014-11-14  6:09       ` Luca Coelho
2014-11-14  6:57         ` Marcel Holtmann
2014-11-14  8:41           ` Stanislaw Gruszka
2014-11-14  7:02       ` Marcel Holtmann
2014-11-14  8:42         ` Stanislaw Gruszka
2014-11-14 16:02         ` Dan Williams
2014-11-14 17:10           ` Dan Williams
2014-11-19 17:13             ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415933817.2629.14.camel@dcbw.local \
    --to=dcbw@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).