From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless@vger.kernel.org, luca@coelho.fi
Subject: Re: [RFC] mac80211: allow drivers to provide any statistics
Date: Mon, 17 Nov 2014 13:23:33 +0100 [thread overview]
Message-ID: <1416227013.2031.1.camel@sipsolutions.net> (raw)
In-Reply-To: <5469E3F7.7020303@broadcom.com>
On Mon, 2014-11-17 at 13:03 +0100, Arend van Spriel wrote:
> > + void (*sta_statistics)(struct ieee80211_hw *hw,
> > + struct ieee80211_vif *vif,
> > + struct ieee80211_sta *sta,
> > + struct station_info *sinfo);
>
> Could consider exposing station_info through ieee80211_sta struct.
We don't keep it in there though, we build it on the fly when we're
asked for statistics, and keep the actual values elsewhere (or even
calculate them on the fly). That'd be a bigger change then to keep in
the struct, and I'm not sure it's worth it since some need more info
than just the value (like ewma) etc.
johannes
next prev parent reply other threads:[~2014-11-17 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 10:48 [RFC] mac80211: allow drivers to provide any statistics Johannes Berg
2014-11-17 11:28 ` Luca Coelho
2014-11-17 12:03 ` Arend van Spriel
2014-11-17 12:23 ` Johannes Berg [this message]
2014-11-19 17:49 ` Bob Copeland
2014-11-19 17:53 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416227013.2031.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).