From: Johannes Berg <johannes@sipsolutions.net>
To: Patrik Flykt <patrik.flykt@linux.intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mac80211-hwsim: Add HWSIM_CMD_GET_RADIO command
Date: Wed, 19 Nov 2014 19:02:07 +0100 [thread overview]
Message-ID: <1416420127.9374.16.camel@sipsolutions.net> (raw)
In-Reply-To: <1415803360-4073-3-git-send-email-patrik.flykt@linux.intel.com> (sfid-20141112_154253_218563_3F2D005A)
On Wed, 2014-11-12 at 16:42 +0200, Patrik Flykt wrote:
> - if (param->reg_alpha2)
> + if (param->reg_alpha2) {
> + data->alpha2[0] = param->reg_alpha2[0];
> + data->alpha2[1] = param->reg_alpha2[1];
> regulatory_hint(hw->wiphy, param->reg_alpha2);
> + }
> + param.reg_alpha2 = data->alpha2;
This seems incorrect, first reg_alpha2 was conditional, and then you
memcpy it, and then you use it unconditionally which may end up as \x00
\x00?
johannes
prev parent reply other threads:[~2014-11-19 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 14:42 [PATCH v2 0/2] Add HWSIM_CMD_GET_RADIO command Patrik Flykt
2014-11-12 14:42 ` [PATCH v2 1/2] mac80211-hwsim: Factor out netlink attribute appending Patrik Flykt
2014-11-19 18:01 ` Johannes Berg
2014-11-12 14:42 ` [PATCH v2 2/2] mac80211-hwsim: Add HWSIM_CMD_GET_RADIO command Patrik Flykt
2014-11-19 18:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416420127.9374.16.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=patrik.flykt@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).