Re: [mac80211-next:master 75/115] include/linux/unaligned/be_struct.h:6:19: error: redefinition of 'get_unaligned_be16'

Re: [mac80211-next:master 75/115] include/linux/unaligned/be_struct.h:6:19: error: redefinition of 'get_unaligned_be16'

[Johannes Berg]

On Wed, 2014-11-19 at 19:13 +0000, Wu, Fengguang wrote:

>    In file included from arch/microblaze/include/asm/unaligned.h:21:0,
>                     from include/linux/ieee80211.h:22,
>                     from drivers/net/wireless/brcm80211/include/brcmu_wifi.h:21,
>                     from drivers/net/wireless/brcm80211/brcmfmac/pcie.c:30:
> >> include/linux/unaligned/be_struct.h:6:19: error: redefinition of 'get_unaligned_be16'
>     static inline u16 get_unaligned_be16(const void *p)
>                       ^
>    In file included from drivers/net/wireless/brcm80211/brcmfmac/pcie.c:22:0:
>    include/linux/unaligned/access_ok.h:22:19: note: previous definition of 'get_unaligned_be16' was here
>     static inline u16 get_unaligned_be16(const void *p)
>                       ^

This is a bug in brcmfmac, it shouldn't be including
<linux/unaligned/access_ok.h> but should include <asm/unaligned.h>
instead.

Now that ieee80211.h is doing the latter, but on microblaze using a
different implementation (not access_ok.h), we get the double
definitions here.

Note that this means that this part of brcmfmac is very broken on all
platforms where access_ok.h cannot be used.

johannes