From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH v2 1/4] cfg80211: leave invalid channels on regdomain change
Date: Thu, 20 Nov 2014 16:17:00 +0100 [thread overview]
Message-ID: <1416496620.8557.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1415895219-19848-1-git-send-email-arik@wizery.com> (sfid-20141113_171404_076764_CE8901A9)
On Thu, 2014-11-13 at 18:13 +0200, Arik Nemtsov wrote:
> When the regulatory settings change, some channels might become invalid.
> Disconnect interfaces acting on these channels, after giving userspace
> code a grace period to leave them.
So as we discussed, I think you should add a note here that the flag
only works for some interface types, and prohibit setting the flag when
unsupported ones are supported. Then you can also remove the message and
just put in a WARN_ON(1) or something since you can't really get to that
code path.
IMHO that's a reasonable trade-off between generalisation and not doing
all the work now especially since you can't validate it over Intel hw
for other interface types - if anyone else needs/wants the flag then
they can add those interface types and change the conditions.
johannes
next prev parent reply other threads:[~2014-11-20 15:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 16:13 [PATCH v2 1/4] cfg80211: leave invalid channels on regdomain change Arik Nemtsov
2014-11-13 16:13 ` [PATCH v2 2/4] cfg80211: update missing fields in custom regulatory path Arik Nemtsov
2014-11-13 22:55 ` Luis R. Rodriguez
2014-11-16 11:01 ` Arik Nemtsov
2014-11-13 16:13 ` [PATCH v2 3/4] cfg80211: allow wiphy specific regdomain management Arik Nemtsov
2014-11-13 23:11 ` Luis R. Rodriguez
2014-11-16 11:06 ` Arik Nemtsov
2014-11-20 20:27 ` Luis R. Rodriguez
2014-11-21 9:17 ` Arik Nemtsov
2014-11-13 16:13 ` [PATCH v2 4/4] cfg80211: Allow usermode to query wiphy specific regd info Arik Nemtsov
2014-11-13 23:13 ` Luis R. Rodriguez
2014-11-16 11:06 ` Arik Nemtsov
2014-11-20 15:22 ` Johannes Berg
2014-11-20 16:47 ` Arik Nemtsov
2014-11-20 20:54 ` Luis R. Rodriguez
2014-11-21 9:33 ` Arik Nemtsov
2014-11-21 23:38 ` Luis R. Rodriguez
2014-11-13 22:45 ` [PATCH v2 1/4] cfg80211: leave invalid channels on regdomain change Luis R. Rodriguez
2014-11-16 11:00 ` Arik Nemtsov
2014-11-20 15:17 ` Johannes Berg
2014-11-20 20:35 ` Luis R. Rodriguez
2014-11-20 20:38 ` Johannes Berg
2014-11-20 20:56 ` Luis R. Rodriguez
2014-11-20 15:17 ` Johannes Berg [this message]
2014-11-20 20:38 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416496620.8557.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).