linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: YanBo <dreamfly281@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: check if channels allow 80 MHz for VHT probe requests
Date: Tue, 25 Nov 2014 15:18:05 +0100	[thread overview]
Message-ID: <1416925085.2045.7.camel@sipsolutions.net> (raw)
In-Reply-To: <CAFuUQkiXfYf1s4UJyvtFT9Jsh=Dd_1vYH6XiJ0B5iSfRxWA8dQ@mail.gmail.com> (sfid-20141125_151401_364139_C8F262C6)

On Tue, 2014-11-25 at 22:13 +0800, YanBo wrote:

> > But is all of that really the right way? I'm not completely convinced.
> 
> Except set the flag, the HW itself should support this feature, or
> else it also doesn't work, I'd
> send the patch in soon for public review.

Yeah, but is it really the right way to advertise VHT? In the spec, VHT
means you also have 80 MHz support - do you really think you can/will do
80 MHz on 2.4 GHz? Seems like all of this will cause more corner cases.

> >
> > I guess we can make this check conditional for 5GHz when the VHT support
> > lands and is discussed.
> >
> That is sounds good if it only check for 5GHz for what I know CMIIW.

Even on 2.4 GHz it technically isn't enough though - there's enough
spectrum in 2.4 GHz for a single 80 MHz channel; how long until somebody
wants to do *that* for some reason? But the rest of us really doesn't
think that's applicable ...

Anyway, it probably needs mac80211 patches anyway since mlme.c already
disables VHT if you can't do 80 MHz, so I think you should post those as
part of a bigger discussion about how we want to support it and what it
really means etc.

johannes


  reply	other threads:[~2014-11-25 14:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 10:23 [PATCH] mac80211: check if channels allow 80 MHz for VHT probe requests Johannes Berg
2014-11-25 11:00 ` YanBo
2014-11-25 11:04   ` Johannes Berg
2014-11-25 11:10     ` YanBo
2014-11-25 12:07       ` Johannes Berg
2014-11-25 14:13         ` YanBo
2014-11-25 14:18           ` Johannes Berg [this message]
2014-11-25 15:09             ` Arend van Spriel
  -- strict thread matches above, loose matches on Subject: below --
2014-11-25 14:49 YanBo
2014-11-25 15:17 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416925085.2045.7.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=dreamfly281@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).