From: Johannes Berg <johannes@sipsolutions.net>
To: vadim4j@gmail.com
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute
Date: Tue, 09 Dec 2014 09:24:18 +0100 [thread overview]
Message-ID: <1418113458.2621.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20141208214845.GA1709@angus-think.lan> (sfid-20141208_225835_436613_04392401)
On Mon, 2014-12-08 at 23:48 +0200, vadim4j@gmail.com wrote:
> What I worry about is this peace of code in net/core/dev.c :
>
> int register_netdevice(struct net_device *dev)
> {
> ...
>
> if (!dev->rtnl_link_ops ||
> dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
> rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U, GFP_KERNEL);
> ...
> }
rtnl_link_state should be RTNL_LINK_INITIALIZED though, unless somebody
set something else.
johannes
next prev parent reply other threads:[~2014-12-09 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 10:20 [PATCH v2] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute Vadim Kochan
2014-12-08 7:27 ` Johannes Berg
2014-12-08 10:07 ` Vadim Kochan
2014-12-08 10:17 ` Johannes Berg
2014-12-08 21:48 ` vadim4j
2014-12-09 8:24 ` Johannes Berg [this message]
2014-12-09 22:08 ` vadim4j
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418113458.2621.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).