linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Vadim Kochan <vadim4j@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute
Date: Wed, 10 Dec 2014 09:12:40 +0100	[thread overview]
Message-ID: <1418199160.3460.2.camel@sipsolutions.net> (raw)
In-Reply-To: <24A120F8-952B-4471-88A6-463CBAD168BE@holtmann.org>

On Wed, 2014-12-10 at 00:23 +0100, Marcel Holtmann wrote:

> have we considered also exposing the mode of this netdev. So for
> example sta,ap,p2p-go,p2p-client etc. If we can send dynamic updates
> via RTNL, we could easily tell the networking management system what
> type of wireless device we have here. I am thinking about it like
> "wlan/p2p-go" etc. Or should this be better kept strictly to "wlan".

I certainly haven't considered this API at all :)
That said, I'm not sure where it would be used, so I don't really know.

> And I am not sure RTNL would be capable of changing this kind strings
> at runtime anyway.

Given the API (fixed constant string in a const struct that the netdev
points to) it seems that it doesn't really support that, unless we
change the internals to have a function to return the string or keep
lots of copies of the struct and reassign them - neither seems very
appealing.

johannes


  parent reply	other threads:[~2014-12-10  8:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 22:21 [PATCH v3] wireless: Supporting of IFLA_INFO_KIND rtnl attribute Vadim Kochan
2014-12-09 23:23 ` Marcel Holtmann
2014-12-09 23:23   ` vadim4j
2014-12-10  8:04     ` Bastian Bittorf
2014-12-10  8:12   ` Johannes Berg [this message]
2014-12-10 20:35     ` Marcel Holtmann
2014-12-10 20:36 ` Marcel Holtmann
2014-12-12 12:43 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418199160.3460.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=marcel@holtmann.org \
    --cc=vadim4j@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).