From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix dot11MulticastTransmittedFrameCount tested address
Date: Tue, 23 Dec 2014 10:10:19 +0100 [thread overview]
Message-ID: <1419325819.1720.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1419168328-6114-1-git-send-email-eliad@wizery.com> (sfid-20141221_142533_445059_B1EE4471)
On Sun, 2014-12-21 at 15:25 +0200, Eliad Peller wrote:
> dot11MulticastTransmittedFrameCount should be updated according
> to the DA, which might be different from hdr1.
>
> (Checking hdr1 results in the counter being 0 in case of station,
> as TODS data frames use hdr1 for the bssid address)
I've found this in the spec - see sta_tx_dcf_3.1d(10) (page 2410 of
802.11-2012):
cTmcfrm:=
If (fsdu!grpa or
((toDs(tpdu) = 1) and (isGrp(addr3(tpdu))) and (fsdu!fTot=fsdu!
fCur+1))
)
then inc(cTmcfrm)
else cTmcfrm fi
fsdu!grpa is true if RA is multicast, but the rest is clearly checking
the DA (and for fragmentation, which can happen in that case.)
So I believe this patch is correct and will apply it (with some commit
message fixes - should say A1 not hdr1)
johannes
prev parent reply other threads:[~2014-12-23 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 13:25 [PATCH] mac80211: fix dot11MulticastTransmittedFrameCount tested address Eliad Peller
2014-12-21 14:19 ` Fred Chou
2014-12-21 15:27 ` Eliad Peller
2014-12-21 16:25 ` Johannes Berg
2014-12-21 16:37 ` Eliad Peller
2014-12-23 9:10 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419325819.1720.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).