From: Johannes Berg <johannes@sipsolutions.net>
To: Avinash Patil <patila@marvell.com>
Cc: "janusz.dziedzic@tieto.com" <janusz.dziedzic@tieto.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Cathy Luo <cluo@marvell.com>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH] cfg80211: do not check for carrier during start_radar_detect
Date: Tue, 23 Dec 2014 11:37:10 +0100 [thread overview]
Message-ID: <1419331030.6091.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1419330994.6091.2.camel@sipsolutions.net> (sfid-20141223_113642_547667_1737F2DD)
On Tue, 2014-12-23 at 11:36 +0100, Johannes Berg wrote:
> On Tue, 2014-12-23 at 02:30 -0800, Avinash Patil wrote:
> > Oops..
> >
> > Are you talking about this?
> > >>So, at least we should move if (netif_carrier_ok(dev)) check to mac80211 otherwise we might change channel of the running interface (via vif_use_channel).
> >
> > I can move this check to ieee80211_start_radar_detection but I dont have any hardware to test these modifications.
>
> That should be ok - however maybe you don't need those modifications at
> all?
>
> Frankly I'm not even sure how off-channel CAC stuff would work but
> Janusz probably knows what he's talking about :)
Also - maybe we need some sort of capability flag for this, and then the
check doesn't have to move but just be made conditional on not having
the feature?
johannes
next prev parent reply other threads:[~2014-12-23 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 16:35 [PATCH] cfg80211: do not check for carrier during start_radar_detect Avinash Patil
2014-12-01 7:13 ` Janusz Dziedzic
[not found] ` <5FF020A1CFFEEC49BD1E09530C4FF5951B160B81A7@SC-VEXCH1.marvell.com>
2014-12-23 10:13 ` Avinash Patil
2014-12-23 10:26 ` Johannes Berg
2014-12-23 10:30 ` Avinash Patil
2014-12-23 10:36 ` Johannes Berg
2014-12-23 10:37 ` Johannes Berg [this message]
2014-12-23 11:32 ` Avinash Patil
2014-12-23 12:01 ` Johannes Berg
2015-01-07 12:55 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2014-11-28 11:28 Avinash Patil
2014-11-28 15:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419331030.6091.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).