From: Johannes Berg <johannes@sipsolutions.net>
To: Avinash Patil <patila@marvell.com>
Cc: linux-wireless@vger.kernel.org, akarwar@marvell.com,
cluo@marvell.com, janusz.dziedzic@tieto.com
Subject: Re: [PATCH] cfg80211: check for carrier state only when offchanel CAC supported
Date: Mon, 05 Jan 2015 10:21:03 +0100 [thread overview]
Message-ID: <1420449663.1898.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1419425236-17457-1-git-send-email-patila@marvell.com>
On Wed, 2014-12-24 at 04:47 -0800, Avinash Patil wrote:
> + * @NL80211_EXT_FEATURE_OFFCHAN_CAC: This device/driver supports
> + * offchannel Channel Availibility Check(CAC).
as Arend said, please indent (with a tab)
You're also mis-spelling "availability" :)
> * @NUM_NL80211_EXT_FEATURES: number of extended features.
> * @MAX_NL80211_EXT_FEATURES: highest extended feature index.
> */
> enum nl80211_ext_feature_index {
>
> + NL80211_EXT_FEATURE_OFFCHAN_CAC,
Better add it before rather than after the blank line.
johannes
next prev parent reply other threads:[~2015-01-05 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 12:47 [PATCH] cfg80211: check for carrier state only when offchanel CAC supported Avinash Patil
2014-12-24 23:18 ` Arend van Spriel
2015-01-05 9:21 ` Johannes Berg [this message]
2015-01-05 10:58 ` Avinash Patil
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 20:05 Avinash Patil
2014-12-23 14:53 ` Johannes Berg
2014-12-23 15:34 ` Arend van Spriel
2014-12-23 15:38 ` Johannes Berg
2014-12-23 15:40 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420449663.1898.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).