From: Johannes Berg <johannes@sipsolutions.net>
To: wim torfs <wtorfs@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH} mac80211: correction of IFTYPE_AP and IFTYPE_AP_VLAN in ieee80211_do_stop
Date: Tue, 06 Jan 2015 13:25:48 +0100 [thread overview]
Message-ID: <1420547148.1966.27.camel@sipsolutions.net> (raw)
In-Reply-To: <54ABD389.8030409@gmail.com> (sfid-20150106_132236_971222_15D2909D)
On Tue, 2015-01-06 at 13:22 +0100, wim torfs wrote:
> While doing a code review, I noticed that in the latest stable version
> of the kernel (3.18.1) the functionality of IFTYPE_AP and IFTYPE_AP_VLAN
> is switched in ieee80211_do_stop. In the case of IEEE80211_IFTYPE_AP,
> the list of devices in sdata->u.ap.vlans are closed, while in the case
> of IEEE80211_IFTYPE_AP_VLAN the skbs in sdata->bss->ps->bc_buf are
> freed. I believe this should be the other way around.
Well, you're wrong :)
johannes
prev parent reply other threads:[~2015-01-06 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 12:22 [PATCH} mac80211: correction of IFTYPE_AP and IFTYPE_AP_VLAN in ieee80211_do_stop wim torfs
2015-01-06 12:25 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420547148.1966.27.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wtorfs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).