From: Johannes Berg <johannes@sipsolutions.net>
To: Ido Yariv <ido@wizery.com>
Cc: linux-wireless@vger.kernel.org, Ido Yariv <idox.yariv@intel.com>,
Christopher Chavez <chrischavez@gmx.us>,
Christian Lamparter <chunkeey@googlemail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Solomon Peachy <pizza@shaftnet.org>
Subject: Re: [PATCH] mac80211: Re-fix accounting of the tailroom-needed counter
Date: Wed, 07 Jan 2015 14:39:56 +0100 [thread overview]
Message-ID: <1420637996.3407.11.camel@sipsolutions.net> (raw)
In-Reply-To: <1420551542-21981-1-git-send-email-ido@wizery.com> (sfid-20150106_143921_495850_B1F9FB69)
On Tue, 2015-01-06 at 08:39 -0500, Ido Yariv wrote:
> When hw acceleration is enabled, the GENERATE_IV or PUT_IV_SPACE flags
> only require headroom space. Therefore, the tailroom-needed counter can
> safely be decremented for most drivers.
>
> The older incarnation of this patch (ca34e3b5) assumed that the above
> holds true for all drivers. As reported by Christopher Chavez and
> researched by Christian Lamparter and Larry Finger, this isn't a valid
> assumption for p54 and cw1200.
>
> Drivers that still require tailroom for ICV/MIC even when HW encryption
> is enabled can use IEEE80211_KEY_FLAG_RESERVE_TAILROOM to indicate it.
Applied. Let's hope it sticks this time :)
johannes
prev parent reply other threads:[~2015-01-07 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 4:39 p54usb kernel panic on recent mainline kernels Christopher Chavez
2014-12-25 22:27 ` Christian Lamparter
2014-12-26 2:41 ` Larry Finger
2014-12-26 4:23 ` Christopher Chavez
2014-12-26 14:35 ` Christian Lamparter
2014-12-26 19:05 ` Larry Finger
2014-12-27 0:15 ` Christopher Chavez
2014-12-27 10:10 ` Christian Lamparter
2014-12-27 11:57 ` Christian Lamparter
2014-12-27 18:38 ` Larry Finger
2015-01-01 6:52 ` Christopher Chavez
2015-01-05 9:33 ` Johannes Berg
2015-01-05 17:30 ` Larry Finger
2015-01-06 13:39 ` [PATCH] mac80211: Re-fix accounting of the tailroom-needed counter Ido Yariv
2015-01-07 13:39 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420637996.3407.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=chrischavez@gmx.us \
--cc=chunkeey@googlemail.com \
--cc=ido@wizery.com \
--cc=idox.yariv@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).