From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: linux-wireless@vger.kernel.org, nbd@openwrt.org,
thomas@net.t-labs.tu-berlin.de
Subject: Re: [PATCHv4] mac80211: enable TPC through mac80211 stack
Date: Wed, 07 Jan 2015 15:12:09 +0100 [thread overview]
Message-ID: <1420639929.3407.18.camel@sipsolutions.net> (raw)
In-Reply-To: <1420566070-25336-1-git-send-email-lorenzo.bianconi83@gmail.com> (sfid-20150106_184113_066053_088DBBD3)
On Tue, 2015-01-06 at 18:41 +0100, Lorenzo Bianconi wrote:
> + * @txpower_type: TX power adjustment used to control per packet Transmit
> + * Power Control (TPC) in lower driver for the current vif. In particular
> + * TPC is enabled if value passed in %txpower_type is
> + * NL80211_TX_POWER_AUTOMATIC (no limit from userspace) or
> + * NL80211_TX_POWER_LIMITED (allow using less than specified from
> + * userspace), whereas TPC is disabled if %txpower_type is set to
> + * NL80211_TX_POWER_FIXED (use value configured from userspace)
I was going to apply this, but now I have second thoughts.
Does it really make sense to ask the driver to do "automatic"? After
all, there are other limits in mac80211 (like 11h from the AP and
regulatory) that need to be considered. So perhaps if userspace says
"automatic", the driver should still see only "limited"?
johannes
next prev parent reply other threads:[~2015-01-07 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 17:41 [PATCHv4] mac80211: enable TPC through mac80211 stack Lorenzo Bianconi
2015-01-07 14:12 ` Johannes Berg [this message]
2015-01-07 14:39 ` Lorenzo Bianconi
2015-01-08 7:48 ` Johannes Berg
2015-01-08 11:07 ` Lorenzo Bianconi
2015-01-14 8:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420639929.3407.18.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@openwrt.org \
--cc=thomas@net.t-labs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).