From: Johannes Berg <johannes@sipsolutions.net>
To: Giel van Schijndel <me@mortis.eu>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
Eliad Peller <eliad@wizery.com>,
"John W. Linville" <linville@tuxdriver.com>,
Arik Nemtsov <arik@wizery.com>,
"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest
Date: Wed, 07 Jan 2015 23:16:18 +0100 [thread overview]
Message-ID: <1420668978.3407.28.camel@sipsolutions.net> (raw)
In-Reply-To: <20150107191836.GA18978@salidar.dom.custoft.eu>
On Wed, 2015-01-07 at 20:18 +0100, Giel van Schijndel wrote:
> IMO the aligned block of code has the significant advantage of taking
> advantage of humans' ability to spot things that break a pattern. Which
> in this case becomes *very* visible when properly aligned, because
> without the alignment there is no (visual) pattern (or at least not one
> very suitable for my "visual processing system", I know the same applies
> to at least some others).
Yeah, well, but why even invoke that "visual processing system"?
If you look, for example, at the __skb_clone function it just uses a
macro:
#define C(x) n->x = skb->x
and then
C(len);
C(data_len);
etc.
johannes
next prev parent reply other threads:[~2015-01-07 22:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 18:00 [PATCH 1/2] Align member-assigns in a structure-copy block Giel van Schijndel
2015-01-04 18:00 ` [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest Giel van Schijndel
2015-01-04 23:02 ` Giel van Schijndel
2015-01-05 9:54 ` Johannes Berg
2015-01-07 19:18 ` Giel van Schijndel
2015-01-07 22:16 ` Johannes Berg [this message]
2015-01-07 23:06 ` Arend van Spriel
2015-01-04 23:02 ` [PATCH 1/2] Align member-assigns in a structure-copy block Giel van Schijndel
2015-01-05 9:17 ` Kalle Valo
2015-01-05 9:16 ` Kalle Valo
2015-01-07 18:40 ` Andy Shevchenko
2015-01-07 19:38 ` [PATCH RESEND 1/2] wlcore: fix copy-paste bug: assign from src struct not dest Giel van Schijndel
2015-01-07 19:38 ` [PATCH RESEND 2/2] wlcore: align member-assigns in a structure-copy block Giel van Schijndel
2015-01-09 17:03 ` Kalle Valo
2015-01-11 10:22 ` Eliad Peller
2015-01-11 20:32 ` Giel van Schijndel
2015-01-15 13:23 ` Kalle Valo
2015-01-23 17:07 ` [RESEND, 1/2] wlcore: fix copy-paste bug: assign from src struct not dest Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420668978.3407.28.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andy.shevchenko@gmail.com \
--cc=arik@wizery.com \
--cc=eliad@wizery.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@mortis.eu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).