From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
ilw@linux.intel.com
Subject: Re: [PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key
Date: Mon, 12 Jan 2015 22:36:34 +0100 [thread overview]
Message-ID: <1421098594.1891.34.camel@sipsolutions.net> (raw)
In-Reply-To: <1421097491-29574-1-git-send-email-linville@tuxdriver.com> (sfid-20150112_223024_176525_753A4630)
On Mon, 2015-01-12 at 16:18 -0500, John W. Linville wrote:
> Add a comment indicating that the WLAN_CIPHER_SUITE_WEP104 case falls
> through to the WLAN_CIPHER_SUITE_WEP40 case in iwl_mvm_send_sta_key.
> This will document that the lack of a break is intentional.
>
> Coverity: CID 1260023
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> This seems to work, so I'm guessing that the fall-through is
> intentional...
Yeah, it is.
johannes
next prev parent reply other threads:[~2015-01-12 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 21:18 [PATCH] iwlwifi: document switch case fall-through in iwl_mvm_send_sta_key John W. Linville
2015-01-12 21:36 ` Johannes Berg [this message]
2015-01-13 6:00 ` Grumbach, Emmanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421098594.1891.34.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).