From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] mac80211: add VHT support for IBSS
Date: Wed, 14 Jan 2015 09:54:24 +0100 [thread overview]
Message-ID: <1421225664.1950.27.camel@sipsolutions.net> (raw)
In-Reply-To: <1421138124-7661-2-git-send-email-janusz.dziedzic@tieto.com> (sfid-20150113_093621_137245_E694964D)
On Tue, 2015-01-13 at 09:35 +0100, Janusz Dziedzic wrote:
> +++ b/net/mac80211/main.c
> @@ -549,6 +549,7 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len,
> wiphy->features |= NL80211_FEATURE_LOW_PRIORITY_SCAN |
> NL80211_FEATURE_AP_SCAN;
>
> + wiphy_ext_feature_set(wiphy, NL80211_FEATURE_VHT_IBSS);
Maybe we should leave this to the driver?
And it should certainly depend on actual VHT capability, I'd say? Seems
confusing if we ended up with a driver that doesn't have VHT but says it
has VHT_IBSS :)
> +++ b/net/mac80211/util.c
> @@ -2329,6 +2329,41 @@ u8 *ieee80211_ie_build_ht_oper(u8 *pos, struct ieee80211_sta_ht_cap *ht_cap,
> return pos + sizeof(struct ieee80211_ht_operation);
> }
>
> +u8 *ieee80211_ie_build_vht_oper(u8 *pos, struct ieee80211_sta_vht_cap *vht_cap,
> + const struct cfg80211_chan_def *chandef)
For now that'll only be used by IBSS (perhaps mesh in the future?), but
maybe it should just be in ibss.c until it's used more?
johannes
next prev parent reply other threads:[~2015-01-14 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:35 [RFC 1/2] cfg80211: add VHT support for IBSS Janusz Dziedzic
2015-01-13 8:35 ` [RFC 2/2] mac80211: " Janusz Dziedzic
2015-01-14 8:54 ` Johannes Berg [this message]
2015-01-14 8:52 ` [RFC 1/2] cfg80211: " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421225664.1950.27.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).