From: Masashi Honma <masashi.honma@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: me@bobcopeland.com, Masashi Honma <masashi.honma@gmail.com>
Subject: [PATCH v2] mac80211: Avoid STA expiration timer truncation to u32
Date: Fri, 16 Jan 2015 15:18:41 +0900 [thread overview]
Message-ID: <1421389121-2841-1-git-send-email-masashi.honma@gmail.com> (raw)
In-Reply-To: <CAFk-A4kzcC9BhCtwqxjprRiXZeVPepBDXr3TvqvL6hn6J37UGw@mail.gmail.com>
On some combination of plink_timeout and HZ, the STA expiration timer will be
unexpectedly truncated to u32. Maybe there is a question "Who sets such a large
number to plink_timeout ?". At least wpa_supplicant will set 0xffffffff to
plink_timeout to disable this timer because wpa_supplicant has it's own
expiration mechanism.
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
---
net/mac80211/mesh.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
index 0c8b2a7..bb721a0 100644
--- a/net/mac80211/mesh.c
+++ b/net/mac80211/mesh.c
@@ -574,7 +574,8 @@ static void ieee80211_mesh_housekeeping(struct ieee80211_sub_if_data *sdata)
struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
u32 changed;
- ieee80211_sta_expire(sdata, ifmsh->mshcfg.plink_timeout * HZ);
+ ieee80211_sta_expire(sdata, ifmsh->mshcfg.plink_timeout *
+ (unsigned long)HZ);
mesh_path_expire(sdata);
changed = mesh_accept_plinks_update(sdata);
--
2.1.0
next prev parent reply other threads:[~2015-01-16 6:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 5:17 [PATCH] mesh: Avoid STA expiration timer truncation to u32 Masashi Honma
2015-01-16 5:49 ` Kalle Valo
2015-01-16 6:12 ` Masashi Honma
2015-01-16 6:18 ` Masashi Honma [this message]
2015-01-16 13:31 ` [PATCH v2] mac80211: " Bob Copeland
2015-01-20 2:44 ` Masashi Honma
2015-01-20 2:47 ` [PATCH v3] " Masashi Honma
2015-01-23 9:42 ` Johannes Berg
2015-01-23 14:27 ` Masashi Honma
2015-02-04 2:22 ` [PATCH v4] mac80211: Allow 0 for NL80211_MESHCONF_PLINK_TIMEOUT to disable STA expiration Masashi Honma
2015-02-24 9:46 ` Johannes Berg
[not found] ` <CAFk-A4nyEvsaCah97ohnbLW7a0+GRbnuJGLyFkBLbpWVffn85w@mail.gmail.com>
2015-02-24 10:03 ` Fwd: " Masashi Honma
2015-02-24 13:42 ` [PATCH v5] " Masashi Honma
2015-02-24 20:08 ` Johannes Berg
2015-02-24 23:24 ` Masashi Honma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421389121-2841-1-git-send-email-masashi.honma@gmail.com \
--to=masashi.honma@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).