From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFCv2 6/6] mac80211: IBSS setup correctly BW for VHT
Date: Fri, 16 Jan 2015 11:55:03 +0100 [thread overview]
Message-ID: <1421405703.9214.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1421404724-32326-6-git-send-email-janusz.dziedzic@tieto.com> (sfid-20150116_113943_517353_27DA5285)
On Fri, 2015-01-16 at 11:38 +0100, Janusz Dziedzic wrote:
> + /* we both use VHT */
> + struct ieee80211_vht_cap vhtcap_ie;
> + struct ieee80211_sta_vht_cap vht_cap = sta->sta.vht_cap;
> +
> + ieee80211_vht_oper_to_chandef(channel,
> + elems->vht_operation,
> + &chandef);
Ok maybe I'm missing something - but can't this erroneously configure
the local HW to 160 MHz when it doesn't even support it, or so?
> + memcpy(&vhtcap_ie, elems->vht_cap_elem, sizeof(vhtcap_ie));
> + ieee80211_vht_cap_ie_to_sta_vht_cap(sdata, sband, &vhtcap_ie, sta);
> + if (memcmp(&vht_cap, &sta->sta.vht_cap, sizeof(vht_cap)))
> + rates_updated |= true;
Indentation is wrong here.
johannes
next prev parent reply other threads:[~2015-01-16 10:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 10:38 [RFCv2 1/6] mac80211: ibss, fix chandef setup for HT40 Janusz Dziedzic
2015-01-16 10:38 ` [RFCv2 2/6] cfg80211: add VHT support for IBSS Janusz Dziedzic
2015-01-16 10:38 ` [RFCv2 3/6] mac80211: " Janusz Dziedzic
2015-01-16 10:52 ` Johannes Berg
2015-01-16 10:38 ` [RFCv2 4/6] mac80211: IBSS fix scan request Janusz Dziedzic
2015-01-16 10:38 ` [RFCv2 5/6] mac80211: ibss/mesh move bw checking Janusz Dziedzic
2015-01-16 10:38 ` [RFCv2 6/6] mac80211: IBSS setup correctly BW for VHT Janusz Dziedzic
2015-01-16 10:55 ` Johannes Berg [this message]
2015-01-16 12:08 ` Janusz Dziedzic
2015-01-16 12:18 ` Johannes Berg
2015-01-16 12:48 ` Janusz Dziedzic
2015-01-16 10:49 ` [RFCv2 1/6] mac80211: ibss, fix chandef setup for HT40 Johannes Berg
2015-01-16 11:24 ` Janusz Dziedzic
2015-01-16 11:47 ` Johannes Berg
2015-01-16 12:18 ` Janusz Dziedzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421405703.9214.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).