linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, Eyal Shapira <eyal@wizery.com>
Subject: Re: [RFC 2/2] mac80211: support RX rate statistics
Date: Mon, 19 Jan 2015 10:55:24 +0100	[thread overview]
Message-ID: <1421661324.1965.16.camel@sipsolutions.net> (raw)
In-Reply-To: <21689.49345.803049.938915@gargle.gargle.HOWL>

On Sat, 2015-01-17 at 07:24 +0530, Sujith Manoharan wrote:

> We were doing simple RX statistics collection inside ath9k
> (CONFIG_ATH9K_STATION_STATISTICS), which can be removed once this goes
> in. Is there any way a driver can pass custom data, like per-frame
> antenna details ?

Not right now - and there's practically no space left in the rate u16 to
store it.

Eyal also commented that perhaps not just antennas but also
STBC/LDPC/beamforming should be tracked.

We can achieve this by increasing the size of the rate field to u32, but
then we also have far more combinations so probably need to increase the
size of the buffer from 36 entries to more since otherwise we just end
up sending the data out to userspace too frequently? Antennas for
example could change frequently for single stream rates.

This capability right now is mostly intended for Android Lollipop's
statistics requirements, where the rate only matters.

If others want to use it for more, I'm certainly not averse to adding
it, but it'd also mean adding more userspace API (where it might be a
bit strange to add "antennas" to the "rate" since that doesn't impact
the actual rate?)

johannes


  reply	other threads:[~2015-01-19  9:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16  9:48 [RFC 1/2] nl80211: support per-rate/per-station statistics Johannes Berg
2015-01-16  9:48 ` [RFC 2/2] mac80211: support RX rate statistics Johannes Berg
2015-01-17  1:54   ` Sujith Manoharan
2015-01-19  9:55     ` Johannes Berg [this message]
2015-01-20  4:50       ` Sujith Manoharan
2015-01-20 11:06         ` Johannes Berg
2015-01-16 10:49 ` [RFC 1/2] nl80211: support per-rate/per-station statistics Bjørn Mork
2015-01-16 10:50   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421661324.1965.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=eyal@wizery.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sujith@msujith.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).