linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: only roll back station states for WDS when suspending
Date: Mon, 19 Jan 2015 21:33:05 +0100	[thread overview]
Message-ID: <1421699585.1965.45.camel@sipsolutions.net> (raw)
In-Reply-To: <1421699291-16279-1-git-send-email-luca@coelho.fi>

On Mon, 2015-01-19 at 22:28 +0200, Luca Coelho wrote:
> From: Luciano Coelho <luciano.coelho@intel.com>
> 
> In the suspend code, we shouldn't roll back the station states because
> this is taken care of in other parts of the code, except for WDS
> interfaces.  For AP types of interfaces, cfg80211 takes care of
> disconnecting all stations before calling the driver's suspend code.
> For station interfaces, this will be done in the quiesce code.

That's actually correct only in the corner case of ongoing
authentication or association - in the common case of being associated
while suspending it's also handled by cfg80211. Similarly, of course,
for mesh and IBSS.

Would perhaps be worth mentioning that here.

johannes


  reply	other threads:[~2015-01-19 20:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 20:28 [PATCH] mac80211: only roll back station states for WDS when suspending Luca Coelho
2015-01-19 20:33 ` Johannes Berg [this message]
2015-01-21 20:19 ` Luca Coelho
2015-01-23  9:51   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421699585.1965.45.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).