From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
linux-wireless@vger.kernel.org,
Avri Altman <avri.altman@intel.com>
Subject: Re: [PATCH] mac80211: tell drivers the user TX power restriction
Date: Wed, 21 Jan 2015 21:04:10 +0100 [thread overview]
Message-ID: <1421870650.1900.31.camel@sipsolutions.net> (raw)
In-Reply-To: <54BFE7EA.3090402@broadcom.com>
On Wed, 2015-01-21 at 18:54 +0100, Arend van Spriel wrote:
> Okay. Let's forget about the configurable thing. Reading the commit
> message and I concluded that before the patch it was 'txpwr_limit =
> min(user, regulatory, ap_11h)'. So for drivers using this value this now
> changes to 'txpwr_limit = user', right? For those drivers it might be
> good to have the min() operation added so their behaviour is effectively
> unchanged by this patch.
The behaviour stays the same for all existing drivers, but drivers now
get a choice between having the min() value (in the existing
bss_conf.txpower) or using the user-specified power (if they do the
min() of the channel themselves) in bss_conf.user_txpower.
So no - it doesn't change the behaviour, it just gives driver authors
more options, and this is needed like I mentioned before - for hw scan
for example you don't want to limit to the *current* channel (the
"regulatory" in the min()) but to the *scan* channel - which only the
device can do since it does the scanning.
johannes
next prev parent reply other threads:[~2015-01-21 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 20:15 [PATCH] mac80211: tell drivers the user TX power restriction Emmanuel Grumbach
2015-01-20 22:50 ` Arend van Spriel
2015-01-21 16:46 ` Johannes Berg
2015-01-21 17:54 ` Arend van Spriel
2015-01-21 20:04 ` Johannes Berg [this message]
2015-01-23 9:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421870650.1900.31.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=avri.altman@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).