From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFCv3 4/4] mac80211: add VHT support for IBSS
Date: Mon, 26 Jan 2015 09:26:12 +0100 [thread overview]
Message-ID: <1422260772.1890.7.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+XVXfd=dh4_n30y8JzAdo1jNB9eO=qk8mwpzB6vGbSnsk59zg@mail.gmail.com> (sfid-20150125_113036_230083_24A4666B)
On Sun, 2015-01-25 at 12:30 +0200, Arik Nemtsov wrote:
> > + switch (chandef->width) {
> > + case NL80211_CHAN_WIDTH_80:
> > + vht_oper->chan_width = IEEE80211_VHT_CHANWIDTH_80MHZ;
> > + break;
> > + case NL80211_CHAN_WIDTH_80P80:
> > + vht_oper->chan_width = IEEE80211_VHT_CHANWIDTH_80P80MHZ;
> > + vht_oper->center_freq_seg2_idx =
> > + ieee80211_frequency_to_channel(chandef->center_freq2);
> > + break;
> > + case NL80211_CHAN_WIDTH_160:
> > + vht_oper->chan_width = IEEE80211_VHT_CHANWIDTH_160MHZ;
> > + break;
> > + default:
> > + return pos;
> > + }
>
> Shouldn't you also set vht_oper->basic_mcs_set here? Of course if you
> have no use for it in IBSS I can add it later.
Why would you want to require VHT rates?
johannes
next prev parent reply other threads:[~2015-01-26 8:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 12:35 [RFCv3 1/4] mac80211: ibss/mesh move bw checking Janusz Dziedzic
2015-01-20 12:35 ` [RFCv3 2/4] cfg80211: add VHT support for IBSS Janusz Dziedzic
2015-01-23 10:02 ` Johannes Berg
2015-01-20 12:35 ` [RFCv3 3/4] mac80211: IBSS fix scan request Janusz Dziedzic
2015-01-20 12:35 ` [RFCv3 4/4] mac80211: add VHT support for IBSS Janusz Dziedzic
2015-01-23 10:04 ` Johannes Berg
2015-01-25 10:25 ` Arik Nemtsov
2015-01-26 8:26 ` Johannes Berg
2015-01-25 10:30 ` Arik Nemtsov
2015-01-26 8:26 ` Johannes Berg [this message]
2015-01-26 8:37 ` Arik Nemtsov
2015-01-26 9:00 ` Johannes Berg
2015-01-26 9:19 ` Janusz Dziedzic
2015-01-26 9:25 ` Johannes Berg
2015-01-26 9:49 ` Janusz Dziedzic
2015-01-26 10:01 ` Janusz Dziedzic
2015-01-23 10:01 ` [RFCv3 1/4] mac80211: ibss/mesh move bw checking Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422260772.1890.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).